Bugzilla – Attachment 42631 Details for
Bug 14510
Allow column visibility in additem.pl to be customized
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 14510: (QA followup) Fix bug with unmapped columns
Bug-14510-QA-followup-Fix-bug-with-unmapped-column.patch (text/plain), 2.49 KB, created by
Jonathan Druart
on 2015-09-17 07:12:09 UTC
(
hide
)
Description:
Bug 14510: (QA followup) Fix bug with unmapped columns
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2015-09-17 07:12:09 UTC
Size:
2.49 KB
patch
obsolete
>From be57ec8ec927e37e1c3eccc0592e9c35e76d3ea6 Mon Sep 17 00:00:00 2001 >From: Jesse Weaver <pianohacker@gmail.com> >Date: Thu, 6 Aug 2015 12:48:07 -0600 >Subject: [PATCH] Bug 14510: (QA followup) Fix bug with unmapped columns > >Fall back more smoothly when items subfields are not mapped to a >kohafield. Note, however, that this development does not allow applying >default settings to subfields that aren't mapped. A note has been added >to the columns settings page, as there is no known workaround for this. > >Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >--- > koha-tmpl/intranet-tmpl/prog/en/includes/columns_settings.inc | 3 ++- > koha-tmpl/intranet-tmpl/prog/en/modules/admin/columns_settings.tt | 2 +- > 2 files changed, 3 insertions(+), 2 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/columns_settings.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/columns_settings.inc >index c5bbdba..9dd454c 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/columns_settings.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/columns_settings.inc >@@ -10,7 +10,8 @@ function KohaTable(selector, dt_parameters, columns_settings) { > var excluded_ids = []; > $(columns_settings).each( function() { > var named_id = $( 'thead th[data-colname="' + this.columnname + '"]', selector ).index( 'th' ); >- var used_id = named_id == -1 ? id : named_id; >+ var used_id = this.columnname ? named_id : id; >+ if ( used_id == -1 ) return; > > if ( this['is_hidden'] == "1" ) { > hidden_ids.push( used_id ); >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/columns_settings.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/columns_settings.tt >index bb973e6..f4cf802 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/columns_settings.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/columns_settings.tt >@@ -13,7 +13,7 @@ > [% IF tables.$pagename.keys and tables.$pagename.keys.size > 0 %] > [% FOR tablename IN tables.$pagename.keys.sort %] > [% IF pagename == 'additem' AND tablename == 'itemst' %] >- <div class="alert">Saving changes to column visibility here will override framework visibility settings for the table of items.</div> >+ <div class="alert">Changes made below will only apply to item subfields that are <a href="/cgi-bin/koha/admin/koha2marclinks.pl">mapped</a> to the <code>items</code> table.</div> > [% END %] > <table> > <caption> >-- >2.1.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 14510
:
40977
|
41418
|
41419
|
41800
|
42353
|
42379
|
42624
|
42628
|
42629
|
42630
| 42631 |
42632
|
42633