Attachment 42637 Details for Bug 14842 – Bug 14842: Wrong call to GetBranchItemRule

[patch] Bug 14842: Wrong call to GetBranchItemRule

Bug-14842-Wrong-call-to-GetBranchItemRule.patch (text/plain), 1.01 KB, created by Jonathan Druart on 2015-09-17 08:07:59 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2015-09-17 08:07:59 UTC

Size: 1.01 KB

patch

obsolete

>From 5f16ca4f60fec5e89a5d066d9f4239d60ba3876e Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Thu, 17 Sep 2015 09:03:59 +0100
>Subject: [PATCH] Bug 14842: Wrong call to GetBranchItemRule
>
>From bug 7981:
>
>GetBranchItemRule expects an itemtype, a scalar.
>Here $itemtype is a hashref returned by C4::ItemType->get.
>So $itemtype->{itemtype} should be passed.
>---
> circ/returns.pl | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/circ/returns.pl b/circ/returns.pl
>index ec0679f..637f4b2 100755
>--- a/circ/returns.pl
>+++ b/circ/returns.pl
>@@ -276,7 +276,7 @@ if ($barcode) {
>     }
> 
>     # make sure return branch respects home branch circulation rules, default to homebranch
>-    my $hbr = GetBranchItemRule($biblio->{'homebranch'}, $itemtype)->{'returnbranch'} || "homebranch";
>+    my $hbr = GetBranchItemRule($biblio->{'homebranch'}, $itemtype->{itemtype})->{'returnbranch'} || "homebranch";
>     my $returnbranch = $biblio->{$hbr} ;
> 
>     $template->param(
>-- 
>2.1.0

Actions: View | Diff | Splinter Review

Attachments on bug 14842: 42637 | 42803 | 43035