Attachment 42714 Details for Bug 14817 – [PASSED QA] Bug 14817: (follow-up) Fix encoding issues in columns.def

[patch] [PASSED QA] Bug 14817: (follow-up) Fix encoding issues in columns.def

PASSED-QA-Bug-14817-follow-up-Fix-encoding-issues-.patch (text/plain), 1.23 KB, created by Katrin Fischer on 2015-09-19 06:18:16 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Katrin Fischer

Created: 2015-09-19 06:18:16 UTC

Size: 1.23 KB

patch

obsolete

>From 894a9ef656e83eab4921a6d64ab1ae2e032444a5 Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Wed, 16 Sep 2015 09:24:07 +0100
>Subject: [PATCH] [PASSED QA] Bug 14817: (follow-up) Fix encoding issues in
> columns.def
>
>Follow-up for reports.
>
>Test plan:
>1/ Use a translated template (fr-FR or ar-Arab)
>2/ Go on the report guided page, step 3
>3/ The field names should be correctly encoded.
>
>Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
>
>Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
>---
> C4/Reports/Guided.pm | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/C4/Reports/Guided.pm b/C4/Reports/Guided.pm
>index c714213..cb09651 100644
>--- a/C4/Reports/Guided.pm
>+++ b/C4/Reports/Guided.pm
>@@ -884,7 +884,7 @@ sub _get_column_defs {
>     my ($theme, $lang, $availablethemes) = C4::Templates::themelanguage($htdocs, 'about.tt', $section, $cgi);
> 
>     my $full_path_to_columns_def_file="$htdocs/$theme/$lang/$columns_def_file";
>-    open (my $fh, $full_path_to_columns_def_file);
>+    open (my $fh, '<:encoding(utf-8)', $full_path_to_columns_def_file);
>     while ( my $input = <$fh> ){
>         chomp $input;
>         if ( $input =~ m|<field name="(.*)">(.*)</field>| ) {
>-- 
>1.9.1

Actions: View | Diff | Splinter Review

Attachments on bug 14817: 42524 | 42571 | 42582 | 42583 | 42713 | 42714