Attachment 42735 Details for Bug 14733 – Bug 14733 - Prevent a record from having holds with duplicate priorities

[patch] Bug 14733 - Prevent a record from having holds with duplicate priorities

Bug-14733---Prevent-a-record-from-having-holds-wit.patch (text/plain), 1.49 KB, created by Jonathan Druart on 2015-09-21 15:46:32 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2015-09-21 15:46:32 UTC

Size: 1.49 KB

patch

obsolete

>From 57eda24ee8aebaec7434687242052a39dc56c05a Mon Sep 17 00:00:00 2001
>From: Kyle M Hall <kyle@bywatersolutions.com>
>Date: Wed, 26 Aug 2015 11:43:08 -0400
>Subject: [PATCH] Bug 14733 - Prevent a record from having holds with duplicate
> priorities
>
>It is possible to create holds with duplicate priorities.
>
>The reason for this is that typically the priority is calculated before
>placing the hold. When the hold is placed the priority is calculated.
>This can easily be shown by opening up two browser windows and starting
>to place a hold for a record in each one. You'll see that both list the
>same priority. If you than place the hold in each window, both holds
>will have the same priority!
>
>Test Plan:
>1) Run unit tests pre-patch, note they fail
>2) Run unit tests post-patch, note they succeed
>
>Signed-off-by: Heather Braum <hbraum@nekls.org>
>
>Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>---
> C4/Reserves.pm | 2 ++
> 1 file changed, 2 insertions(+)
>
>diff --git a/C4/Reserves.pm b/C4/Reserves.pm
>index 5f0bf64..80ebf0a 100644
>--- a/C4/Reserves.pm
>+++ b/C4/Reserves.pm
>@@ -193,6 +193,8 @@ sub AddReserve {
>     my $fee = GetReserveFee( $borrowernumber, $biblionumber );
>     ChargeReserveFee( $borrowernumber, $fee, $title );
> 
>+    _FixPriority({ biblionumber => $biblionumber});
>+
>     # Send e-mail to librarian if syspref is active
>     if(C4::Context->preference("emailLibrarianWhenHoldIsPlaced")){
>         my $borrower = C4::Members::GetMember(borrowernumber => $borrowernumber);
>-- 
>2.1.0

Actions: View | Diff | Splinter Review

Attachments on bug 14733: 41996 | 41997 | 41998 | 42658 | 42659 | 42734 | 42735 | 42736 | 42880