Attachment 42809 Details for Bug 14879 – Bug 14879 - Remove C4::Dates from catalogue/detail.pl

[patch] Bug 14879 - Remove C4::Dates from catalogue/detail.pl

Bug-14879---Remove-C4Dates-from-cataloguedetailpl.patch (text/plain), 2.44 KB, created by Josef Moravec on 2015-09-23 14:31:43 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Josef Moravec

Created: 2015-09-23 14:31:43 UTC

Size: 2.44 KB

patch

obsolete

>From b2de890b3dc1bae20643c95e1b2bfb39d1494906 Mon Sep 17 00:00:00 2001
>From: =?UTF-8?q?Marc=20V=C3=A9ron?= <veron@veron.ch>
>Date: Sun, 20 Sep 2015 23:36:32 +0200
>Subject: [PATCH] Bug 14879 - Remove C4::Dates from catalogue/detail.pl
>
>This bug removes deprecated C4::Dates from catalogue/detail.pl
>
>To test:
>Apply patch
>Go to Home > Catalog > Details for [some biblio with items and holdings]
>Make sure that biblio and Holdings and Acquisition details display as appropriate
>
>Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
>---
> catalogue/detail.pl | 7 +++----
> 1 file changed, 3 insertions(+), 4 deletions(-)
>
>diff --git a/catalogue/detail.pl b/catalogue/detail.pl
>index 2a6dddb..ca3497f 100755
>--- a/catalogue/detail.pl
>+++ b/catalogue/detail.pl
>@@ -22,7 +22,6 @@ use warnings;
> use CGI qw ( -utf8 );
> use C4::Acquisition qw( GetHistory );
> use C4::Auth;
>-use C4::Dates qw/format_date/;
> use C4::Koha;
> use C4::Serials;    #uses getsubscriptionfrom biblionumber
> use C4::Output;
>@@ -207,7 +206,7 @@ foreach my $item (@items) {
>                                                : '';
> 
> 	foreach (qw(datelastseen onloan)) {
>-		$item->{$_} = format_date($item->{$_});
>+		$item->{$_} = output_pref({ dt => dt_from_string( $item->{$_} ), dateonly => 1 });
>     }
>     $item->{datedue} = format_sqldatetime($item->{datedue});
>     # item damaged, lost, withdrawn loops
>@@ -237,7 +236,7 @@ foreach my $item (@items) {
> 
>     if ( defined $reservedate ) {
>         $item->{backgroundcolor} = 'reserved';
>-        $item->{reservedate}     = format_date($reservedate);
>+        $item->{reservedate}     = output_pref({ dt => dt_from_string($reservedate ), dateonly => 1 });
>         $item->{ReservedForBorrowernumber}     = $reservedfor;
>         $item->{ReservedForSurname}     = $ItemBorrowerReserveInfo->{'surname'};
>         $item->{ReservedForFirstname}   = $ItemBorrowerReserveInfo->{'firstname'};
>@@ -251,7 +250,7 @@ foreach my $item (@items) {
> 	# Check the transit status
>     my ( $transfertwhen, $transfertfrom, $transfertto ) = GetTransfers($item->{itemnumber});
>     if ( defined( $transfertwhen ) && ( $transfertwhen ne '' ) ) {
>-        $item->{transfertwhen} = format_date($transfertwhen);
>+        $item->{transfertwhen} = output_pref({ dt => dt_from_string($transfertwhen ), dateonly => 1 });
>         $item->{transfertfrom} = $branches->{$transfertfrom}{branchname};
>         $item->{transfertto}   = $branches->{$transfertto}{branchname};
>         $item->{nocancel} = 1;
>-- 
>2.1.4

Actions: View | Diff | Splinter Review

Attachments on bug 14879: 42797 | 42798 | 42809 | 42810 | 42836 | 42837