Bugzilla – Attachment 4281 Details for
Bug 6417
Template variable errors in Guided Reports
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Proposed fix
0001-Fix-for-Bug-6417-Template-variable-errors-in-Guided-.patch (text/plain), 2.66 KB, created by
Owen Leonard
on 2011-05-27 14:43:38 UTC
(
hide
)
Description:
Proposed fix
Filename:
MIME Type:
Creator:
Owen Leonard
Created:
2011-05-27 14:43:38 UTC
Size:
2.66 KB
patch
obsolete
>From 25267069c5171be16ea3cb45d9022a038daa6592 Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Fri, 27 May 2011 10:41:07 -0400 >Subject: [PATCH] Fix for Bug 6417 - Template variable errors in Guided Reports >Content-Type: text/plain; charset="utf-8" > >Looks like the T:T conversion script missed these instances >of TMPL markup because they had line breaks: > ><!-- TMPL_VAR >NAME="name" --> >--- > .../en/modules/reports/guided_reports_start.tt | 13 +++---------- > 1 files changed, 3 insertions(+), 10 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt >index 589bcdf..04cfb43 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt >@@ -392,8 +392,7 @@ canned reports and writing custom SQL reports.</p> > [% IF ( definitions ) %] > <fieldset><legend>Dictionary Definitions</legend><table> > [% FOREACH definition IN definitions %] >- <tr><td><input type="checkbox" name="definition" value="<!-- >-TMPL_VAR NAME="id" -->" /> [% definition.name %]</td></tr> >+ <tr><td><input type="checkbox" name="definition" value="[% id %]" /> [% definition.name %]</td></tr> > [% END %] > </table> > [% END %] >@@ -415,10 +414,7 @@ TMPL_VAR NAME="id" -->" /> [% definition.name %]</td></tr> > <input type="hidden" name="criteria" value="[% criteriastring %]" /> > <fieldset><table> > [% FOREACH total_b IN total_by %] >-<tr><td><input type="checkbox" name="total_by" id="<!-- TMPL_VAR >-NAME="name" -->" value="<!-- TMPL_VAR >-NAME="name" -->" /> <label for="<!-- TMPL_VAR >-NAME="name" -->">[% total_b.name %]</label></td> >+<tr><td><input type="checkbox" name="total_by" id="[% total_b.name %]" value="[% total_b.name %]" /> <label for="[% total_b.name %]">[% total_b.name %]</label></td> > <td><select name="[% total_b.name %]_tvalue"> > > [% FOREACH selec IN total_b.select %] >@@ -447,10 +443,7 @@ NAME="name" -->">[% total_b.name %]</label></td> > <input type="hidden" name="definition" value="[% definition %]" /> > <input type="hidden" name="totals" value="[% totals %]" /> > <fieldset><table>[% FOREACH order_b IN order_by %] >-<tr><td><input type="checkbox" id="<!-- TMPL_VAR >-NAME="name" -->" name="order_by" value="<!-- TMPL_VAR >-NAME="name" -->" /> <label for="<!-- TMPL_VAR >-NAME="name" -->">[% order_b.name %]</label></td><td> >+<tr><td><input type="checkbox" id="[% order_b.name %]" name="order_by" value="[% order_b.name %]" /> <label for="[% order_b.name %]">[% order_b.name %]</label></td><td> > <select name="[% order_b.name %]_ovalue"> > > [% FOREACH selec IN order_b.select %] >-- >1.7.3 >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 6417
:
4279
|
4280
| 4281