Attachment 42811 Details for Bug 14882 – Bug 14882 - Librarian's are not warned if patron owe more than maxoutstanding

[patch] Bug 14882 - Librarian's are not warned if patron owe more than maxoutstanding

Bug-14882---Librarians-are-not-warned-if-patron-ow.patch (text/plain), 2.87 KB, created by Kyle M Hall (khall) on 2015-09-23 14:40:03 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Kyle M Hall (khall)

Created: 2015-09-23 14:40:03 UTC

Size: 2.87 KB

patch

obsolete

>From 94b794c8d750c1a7c29a72f8b59f96a59eb22ff9 Mon Sep 17 00:00:00 2001
>From: Kyle M Hall <kyle@bywatersolutions.com>
>Date: Wed, 23 Sep 2015 10:38:32 -0400
>Subject: [PATCH] Bug 14882 - Librarian's are not warned if patron owe more than maxoutstanding
>
>If a patron owes more than the system preference maxoutstanding in fees
>and fines, the patron will be unable to place holds via the opac.
>However, a librarian placing a hold for a patron is not even warned!
>
>Test Plan:
>1) Apply this patch
>2) Set amountoutstanding to 1.00
>3) Find a patron owing more than 1.00
>4) Attempt to place a hold
>5) Note the warning that the patron owes money
>---
> .../prog/en/modules/reserve/request.tt | 5 +++++
> reserve/request.pl | 4 +++-
> 2 files changed, 8 insertions(+), 1 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt
>index a6a8f91..1a62e91 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt
>@@ -1,3 +1,4 @@
>+[% USE Koha %]
> [% USE KohaDates %]
> [% INCLUDE 'doc-head-open.inc' %]
> [% UNLESS ( multi_hold ) %]
>@@ -332,6 +333,10 @@ function checkMultiHold() {
> <li><a href="/cgi-bin/koha/members/moremember.pl?borrowernumber=[% borrowernumber %]">[% borrowerfirstname %] [% borrowersurname %]</a>'s account has expired</li>
> [% END %]
> 
>+ [% IF amount_outstanding && Koha.Preference('maxoutstanding') && amount_outstanding > Koha.Preference('maxoutstanding') %]
>+ <li><a href="/cgi-bin/koha/members/pay.pl?borrowernumber=[% borrowernumber %]">[% borrowerfirstname %] [% borrowersurname %]</a> owes [% amount_outstanding | format('%.2f') %]</li>
>+ [% END %]
>+
> [% IF ( diffbranch ) %]
> <li> Pickup library is different than <a href="/cgi-bin/koha/members/moremember.pl?borrowernumber=[% borrowernumber %]">[% borrowerfirstname %] [% borrowersurname %]</a>'s home library ([% borrower_branchname %] / [% borrower_branchcode %] )</li>
> [% END %]
>diff --git a/reserve/request.pl b/reserve/request.pl
>index 0d82f1c..4281d87 100755
>--- a/reserve/request.pl
>+++ b/reserve/request.pl
>@@ -44,6 +44,7 @@ use C4::Utils::DataTables::Members;
> use C4::Members;
> use C4::Search;		# enabled_staff_search_views
> use Koha::DateUtils;
>+use Koha::Borrower::Debarments qw(IsDebarred);
> 
> my $dbh = C4::Context->dbh;
> my $sth;
>@@ -175,7 +176,8 @@ if ($borrowernumber_hold && !$action) {
> expiry => $expiry,
> diffbranch => $diffbranch,
> messages => $messages,
>- warnings => $warnings
>+ warnings => $warnings,
>+ amount_outstanding => GetMemberAccountRecords($borrowerinfo->{borrowernumber}),
> );
> }
> 
>-- 
>1.7.2.5

Actions: View | Diff | Splinter Review

Attachments on bug 14882: 42811 | 42812 | 42813 | 42832 | 42838