Attachment 42832 Details for Bug 14882 – [Signed-off] Bug 14882 - Librarians are not warned if patron owe more than maxoutstanding when placing holds

[patch] [Signed-off] Bug 14882 - Librarians are not warned if patron owe more than maxoutstanding when placing holds

Signed-off-Bug-14882---Librarians-are-not-warned-i.patch (text/plain), 2.84 KB, created by Marc Véron on 2015-09-24 06:47:45 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Marc Véron

Created: 2015-09-24 06:47:45 UTC

Size: 2.84 KB

patch

obsolete

>From c406442b94943698f67c8da3247a9b5a86244012 Mon Sep 17 00:00:00 2001
>From: Kyle M Hall <kyle@bywatersolutions.com>
>Date: Wed, 23 Sep 2015 10:38:32 -0400
>Subject: [PATCH] [Signed-off] Bug 14882 - Librarians are not warned if patron
> owe more than maxoutstanding when placing holds
>MIME-Version: 1.0
>Content-Type: text/plain; charset=UTF-8
>Content-Transfer-Encoding: 8bit
>
>If a patron owes more than the system preference maxoutstanding in fees
>and fines, the patron will be unable to place holds via the opac.
>However, a librarian placing a hold for a patron is not even warned!
>
>Test Plan:
>1) Apply this patch
>2) Set maxoutstanding to 1.00
>3) Find a patron owing more than 1.00
>4) Attempt to place a hold
>5) Note the warning that the patron owes money
>
>Works as expected.
>Signed-off-by: Marc VÃ©ron <veron@veron.ch>
>---
> koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt | 5 +++++
> reserve/request.pl | 3 ++-
> 2 files changed, 7 insertions(+), 1 deletion(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt
>index a6a8f91..1a62e91 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt
>@@ -1,3 +1,4 @@
>+[% USE Koha %]
> [% USE KohaDates %]
> [% INCLUDE 'doc-head-open.inc' %]
> [% UNLESS ( multi_hold ) %]
>@@ -332,6 +333,10 @@ function checkMultiHold() {
> <li><a href="/cgi-bin/koha/members/moremember.pl?borrowernumber=[% borrowernumber %]">[% borrowerfirstname %] [% borrowersurname %]</a>'s account has expired</li>
> [% END %]
> 
>+ [% IF amount_outstanding && Koha.Preference('maxoutstanding') && amount_outstanding > Koha.Preference('maxoutstanding') %]
>+ <li><a href="/cgi-bin/koha/members/pay.pl?borrowernumber=[% borrowernumber %]">[% borrowerfirstname %] [% borrowersurname %]</a> owes [% amount_outstanding | format('%.2f') %]</li>
>+ [% END %]
>+
> [% IF ( diffbranch ) %]
> <li> Pickup library is different than <a href="/cgi-bin/koha/members/moremember.pl?borrowernumber=[% borrowernumber %]">[% borrowerfirstname %] [% borrowersurname %]</a>'s home library ([% borrower_branchname %] / [% borrower_branchcode %] )</li>
> [% END %]
>diff --git a/reserve/request.pl b/reserve/request.pl
>index 0d82f1c..8ddbb84 100755
>--- a/reserve/request.pl
>+++ b/reserve/request.pl
>@@ -175,7 +175,8 @@ if ($borrowernumber_hold && !$action) {
> expiry => $expiry,
> diffbranch => $diffbranch,
> messages => $messages,
>- warnings => $warnings
>+ warnings => $warnings,
>+ amount_outstanding => GetMemberAccountRecords($borrowerinfo->{borrowernumber}),
> );
> }
> 
>-- 
>1.7.10.4

Actions: View | Diff | Splinter Review

Attachments on bug 14882: 42811 | 42812 | 42813 | 42832 | 42838