Bugzilla – Attachment 4286 Details for
Bug 6415
Can't make a patron card batch
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Signed off patch
0001-SIGNED-OFF-Bug-6415-Can-t-make-patron-card-batch.patch (text/plain), 3.17 KB, created by
Magnus Enger
on 2011-05-27 22:04:47 UTC
(
hide
)
Description:
Signed off patch
Filename:
MIME Type:
Creator:
Magnus Enger
Created:
2011-05-27 22:04:47 UTC
Size:
3.17 KB
patch
obsolete
>From af81c87ed181a4262ee7ec4378f045bf846486d6 Mon Sep 17 00:00:00 2001 >From: Katrin Fischer <Katrin.Fischer.83@web.de> >Date: Fri, 27 May 2011 07:46:06 +0200 >Subject: [PATCH] [SIGNED-OFF] Bug 6415: Can't make patron card batch > >TT corrections from bug 6343 for label creator were also needed for patron card creator. > >- Manage Batch and New Batch were missing the branch info >- Add link on patron search was missing batch id parameter > >To test: >- Check branch is correctly shown on pages 'Manage Batch' and 'New Batch' >- Check you can create a new batch and add names to it by using the 'Add' >right to the patron's name > >Signed-off-by: Magnus Enger <magnus@enger.priv.no> >--- > .../prog/en/modules/patroncards/members-search.tt | 2 +- > patroncards/edit-batch.pl | 2 +- > patroncards/manage.pl | 2 +- > 3 files changed, 3 insertions(+), 3 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/patroncards/members-search.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/patroncards/members-search.tt >index 55095d9..a67c080 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/patroncards/members-search.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/patroncards/members-search.tt >@@ -118,7 +118,7 @@ function add_item(borrowernum,batch_id,type_id){ > <td>[% resultsloo.branchcode %]</td> > <td>[% resultsloo.dateexpiry %]</td> > <td>[% resultsloo.borrowernotes %]</td> >- <td><a onclick="add_item('[% resultsloo.borrowernumber %]',[% resultsloo.batch_id %]); return false" href="/cgi-bin/koha/patroncards/edit-batch.pl?borrower_number=[% resultsloo.borrowernumber %]&batch_id=[% resultsloo.batch_id %]&op=add">Add</a></td> >+ <td><a onclick="add_item('[% resultsloo.borrowernumber %]',[% batch_id %]); return false" href="/cgi-bin/koha/patroncards/edit-batch.pl?borrower_number=[% resultsloo.borrowernumber %]&batch_id=[% batch_id %]&op=add">Add</a></td> > </tr> > [% END %] > </table> >diff --git a/patroncards/edit-batch.pl b/patroncards/edit-batch.pl >index 449e82a..50bbbf4 100755 >--- a/patroncards/edit-batch.pl >+++ b/patroncards/edit-batch.pl >@@ -60,7 +60,7 @@ my @item_numbers = $cgi->param('item_number') if $cgi->param('item_number'); > my @borrower_numbers = $cgi->param('borrower_number') if $cgi->param('borrower_number'); > my $errstr = $cgi->param('error') || ''; > >-my $branch_code = get_branch_code_from_name($template->param('LoginBranchname')); >+my $branch_code = get_branch_code_from_name($template->{VARS}->{'LoginBranchname'}); > > if ($op eq 'remove') { > $batch = C4::Patroncards::Batch->retrieve(batch_id => $batch_id); >diff --git a/patroncards/manage.pl b/patroncards/manage.pl >index 2a449ba..71e1b82 100755 >--- a/patroncards/manage.pl >+++ b/patroncards/manage.pl >@@ -73,7 +73,7 @@ my $display_columns = { layout => [ # db column => {col label > }; > > my $errstr = ($cgi->param('error') ? $cgi->param('error') : ''); >-my $branch_code = ($card_element eq 'batch' ? get_branch_code_from_name($template->param('LoginBranchname')) : ''); >+my $branch_code = ($card_element eq 'batch' ? get_branch_code_from_name($template->{VARS}->{'LoginBranchname'}) : ''); > > if ($op eq 'delete') { > my $err = 0; >-- >1.7.4.1 >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 6415
:
4274
| 4286