Attachment 42877 Details for Bug 13799 – [SIGNED OFF] Bug 13799: Fix API unit tests

[patch] [SIGNED OFF] Bug 13799: Fix API unit tests

SIGNED-OFF-Bug-13799-Fix-API-unit-tests.patch (text/plain), 2.30 KB, created by Tomás Cohen Arazi (tcohen) on 2015-09-25 13:01:17 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Tomás Cohen Arazi (tcohen)

Created: 2015-09-25 13:01:17 UTC

Size: 2.30 KB

patch

obsolete

>From 6da19eaefe1a3d32b61f9291cd7ae006acf66310 Mon Sep 17 00:00:00 2001
>From: Julian Maurice <julian.maurice@biblibre.com>
>Date: Wed, 23 Sep 2015 10:06:13 +0200
>Subject: [PATCH] [SIGNED OFF] Bug 13799: Fix API unit tests
>
>They were failing because of the now required 'borrowers' permission
>
>Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
>---
> t/db_dependent/api/v1/borrowers.t | 31 +++++++++++++++++++++++++++++--
> 1 file changed, 29 insertions(+), 2 deletions(-)
>
>diff --git a/t/db_dependent/api/v1/borrowers.t b/t/db_dependent/api/v1/borrowers.t
>index 3f2b178..aef9f4d 100644
>--- a/t/db_dependent/api/v1/borrowers.t
>+++ b/t/db_dependent/api/v1/borrowers.t
>@@ -17,9 +17,10 @@
> 
> use Modern::Perl;
> 
>-use Test::More tests => 6;
>+use Test::More tests => 10;
> use Test::Mojo;
> 
>+use C4::Auth;
> use C4::Context;
> 
> use Koha::Database;
>@@ -29,6 +30,7 @@ my $dbh = C4::Context->dbh;
> $dbh->{AutoCommit} = 0;
> $dbh->{RaiseError} = 1;
> 
>+$ENV{REMOTE_ADDR} = '127.0.0.1';
> my $t = Test::Mojo->new('Koha::REST::V1');
> 
> my $categorycode = Koha::Database->new()->schema()->resultset('Category')->first()->categorycode();
>@@ -42,9 +44,34 @@ $borrower->store;
> my $borrowernumber = $borrower->borrowernumber;
> 
> $t->get_ok('/api/v1/borrowers')
>-  ->status_is(200);
>+  ->status_is(403);
> 
> $t->get_ok("/api/v1/borrowers/$borrowernumber")
>+  ->status_is(403);
>+
>+my $loggedinuser = Koha::Borrower->new;
>+$loggedinuser->categorycode($categorycode);
>+$loggedinuser->branchcode($branchcode);
>+$loggedinuser->userid('test_rest_api_user');
>+$loggedinuser->flags(16); # flags for 'borrowers' permission only
>+$loggedinuser->store;
>+
>+my $session = C4::Auth::get_session('');
>+$session->param('number', $loggedinuser->borrowernumber);
>+$session->param('id', $loggedinuser->userid);
>+$session->param('ip', '127.0.0.1');
>+$session->param('lasttime', time());
>+$session->flush;
>+
>+my $tx = $t->ua->build_tx(GET => '/api/v1/borrowers');
>+$tx->req->cookies({name => 'CGISESSID', value => $session->id});
>+$tx->req->env({REMOTE_ADDR => '127.0.0.1'});
>+$t->request_ok($tx)
>+  ->status_is(200);
>+
>+$tx = $t->ua->build_tx(GET => "/api/v1/borrowers/$borrowernumber");
>+$tx->req->cookies({name => 'CGISESSID', value => $session->id});
>+$t->request_ok($tx)
>   ->status_is(200)
>   ->json_is('/borrowernumber' => $borrowernumber)
>   ->json_is('/surname' => "Test Surname");
>-- 
>2.5.3

Actions: View | Diff | Splinter Review

Attachments on bug 13799: 36700 | 36705 | 36938 | 36941 | 37119 | 37132 | 37172 | 38246 | 39156 | 39158 | 39159 | 39160 | 39161 | 39162 | 39163 | 39164 | 40088 | 40092 | 40093 | 40094 | 40098 | 40099 | 40101 | 40140 | 40141 | 40142 | 40463 | 40464 | 40465 | 40466 | 40467 | 40468 | 40469 | 40470 | 40471 | 40551 | 40552 | 40553 | 40554 | 40560 | 40561 | 40584 | 40585 | 40586 | 40587 | 40616 | 40617 | 40618 | 40619 | 41160 | 41161 | 41162 | 41268 | 41269 | 41270 | 41271 | 41272 | 41273 | 41274 | 41320 | 41321 | 41326 | 41327 | 41328 | 41329 | 41330 | 41331 | 41538 | 41539 | 41540 | 41541 | 41542 | 41543 | 41547 | 41554 | 42044 | 42085 | 42086 | 42123 | 42518 | 42766 | 42768 | 42801 | 42874 | 42875 | 42876 | 42877 | 42878 | 43186 | 43187 | 43189 | 43190 | 43191 | 43192 | 43204 | 43205 | 43206 | 43207 | 43208 | 43209 | 43210 | 43211 | 43212 | 43213 | 43214 | 43980 | 43981 | 43987 | 43989 | 43990 | 43991 | 43992 | 43993 | 43994 | 43995 | 43996 | 43997 | 43998 | 43999 | 44000 | 44001 | 44185 | 44285 | 44313 | 44375 | 44376 | 44377 | 44378 | 44379 | 44380 | 44381 | 44382 | 44383 | 44384 | 44385