Bugzilla – Attachment 42961 Details for
Bug 12311
Batch modification of checked out and lost items checks them in
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[PASSED QA] Bug 12311: Do not return a lost item if modified in a batch
PASSED-QA-Bug-12311-Do-not-return-a-lost-item-if-m.patch (text/plain), 2.19 KB, created by
Katrin Fischer
on 2015-09-29 21:08:05 UTC
(
hide
)
Description:
[PASSED QA] Bug 12311: Do not return a lost item if modified in a batch
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2015-09-29 21:08:05 UTC
Size:
2.19 KB
patch
obsolete
>From 24a62487aa64cc064d1d1758d9215aafe47decfb Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Tue, 15 Sep 2015 11:44:32 +0100 >Subject: [PATCH] [PASSED QA] Bug 12311: Do not return a lost item if modified > in a batch >MIME-Version: 1.0 >Content-Type: text/plain; charset=UTF-8 >Content-Transfer-Encoding: 8bit > >If a item is lost and issued, and you modify it in a batch, the item >will be marked as returned. It should only be returned if the item is >marked as lost. > >Test plan: >1/ Check an item out and mark it as lost >2/ Edit it in a batch (tools/batchMod.pl) and edit a field (notes for >instance) >3/ The item should still be issued to the patron >4/ Edit it in a batch and edit the lost value, marked it as not lost >5/ The item should still be issued to the patron >6/ Edit it in a batch and edit the lost value, marked it as lost >7/ The item should have been returned. > >Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> >Works as advertised. Just one comment, lost status can be changed only if you change default framework to another framework then edit the item. If you change it in Item menu at left side of screen this will remove the item from patronĂ¢s checkouts and patron charged for lost item. > >Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> >For testing purposes the lost item field can be set to visible >in the framework used. That will allow changing it without >returning it at the same time. >The other option is using the longoverdues.pl script. >--- > tools/batchMod.pl | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/tools/batchMod.pl b/tools/batchMod.pl >index 4ed0f10..5108419 100755 >--- a/tools/batchMod.pl >+++ b/tools/batchMod.pl >@@ -198,7 +198,7 @@ if ($op eq "action") { > if ( $modified ) { > eval { > if ( my $item = ModItemFromMarc( $localmarcitem, $itemdata->{biblionumber}, $itemnumber ) ) { >- LostItem($itemnumber, 'MARK RETURNED') if $item->{itemlost}; >+ LostItem($itemnumber, 'MARK RETURNED') if $item->{itemlost} and not $itemdata->{itemlost}; > } > }; > } >-- >1.9.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 12311
:
42554
|
42796
| 42961