Bugzilla – Attachment 42982 Details for
Bug 14880
Keyboard shortcuts don't work after setting CircAutocompl to "Don't try"
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[PASSED QA] Bug 14880: Keyboard shortcuts don't work after setting CircAutocompl to "Don't try"
PASSED-QA-Bug-14880-Keyboard-shortcuts-dont-work-a.patch (text/plain), 2.32 KB, created by
Katrin Fischer
on 2015-09-30 21:51:52 UTC
(
hide
)
Description:
[PASSED QA] Bug 14880: Keyboard shortcuts don't work after setting CircAutocompl to "Don't try"
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2015-09-30 21:51:52 UTC
Size:
2.32 KB
patch
obsolete
>From 06a00eacd57ae02fb7df9bb868d1fe1731ba6769 Mon Sep 17 00:00:00 2001 >From: Lari Taskula <larit@student.uef.fi> >Date: Fri, 25 Sep 2015 14:06:40 +0000 >Subject: [PATCH] [PASSED QA] Bug 14880: Keyboard shortcuts don't work after > setting CircAutocompl to "Don't try" >MIME-Version: 1.0 >Content-Type: text/plain; charset=UTF-8 >Content-Transfer-Encoding: 8bit > >The issue is that CircAutocompl loads a script element under #header_search >element. When this element is missing, it also messes up the indexing, >because we were calculating the indexing of the found element by subtracting >one from the found element's index (to eliminate the <script> element). > >Thats why the shortcut key problem in this bug takes you one too to the left, >because we are still subtracting one from the index even though there is no ><script> element anymore. > >This patches selects only the div elements and gets the index from them. >No subtractions needed. > >To test keys: >1. Set CircAutocompl system preference to Don't try. >2. Try the shortcut keys. They will work incorrectly like this: > Alt+U = Search catalogue > Alt+R = Check out > Alt+Q = Check in >3. Set CircAutocompl system preference to Try. >4. Try the shortcut keys. They will work correctly like this: > Alt+U = Check out > Alt+R = Check in > ALt+Q = Search catalogue >5. Apply patch >6. Repeat step 1 and 4. >7. Repeat step 3 and 4. >8. Observe that regardless of CircAutocompl, shortcut keys worked correctly. > >Followed test plan, works as expected. >Signed-off-by: Marc Véron <veron@veron.ch> > >Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> >--- > koha-tmpl/intranet-tmpl/prog/en/js/staff-global.js | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/js/staff-global.js b/koha-tmpl/intranet-tmpl/prog/en/js/staff-global.js >index c7d962f..2636ec8 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/js/staff-global.js >+++ b/koha-tmpl/intranet-tmpl/prog/en/js/staff-global.js >@@ -18,7 +18,7 @@ function formatstr(str, col) { > > // http://stackoverflow.com/questions/14859281/select-tab-by-name-in-jquery-ui-1-10-0/16550804#16550804 > $.fn.tabIndex = function () { >- return $(this).parent().find(this).index() - 1; >+ return $(this).parent().children('div').index(this); > }; > $.fn.selectTabByID = function (tabID) { > $(this).tabs("option", "active", $(tabID).tabIndex()); >-- >1.9.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 14880
:
42879
|
42945
| 42982