Attachment 43035 Details for Bug 14842 – [PASSED QA] Bug 14842: Wrong call to GetBranchItemRule

[patch] [PASSED QA] Bug 14842: Wrong call to GetBranchItemRule

PASSED-QA-Bug-14842-Wrong-call-to-GetBranchItemRul.patch (text/plain), 1.13 KB, created by Katrin Fischer on 2015-10-01 21:04:19 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Katrin Fischer

Created: 2015-10-01 21:04:19 UTC

Size: 1.13 KB

patch

obsolete

>From 244f312e7f1d6918e92f1aa6e51049eb8dbab754 Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Thu, 17 Sep 2015 09:03:59 +0100
>Subject: [PATCH] [PASSED QA] Bug 14842: Wrong call to GetBranchItemRule
>
>From bug 7981:
>
>GetBranchItemRule expects an itemtype, a scalar.
>Here $itemtype is a hashref returned by C4::ItemType->get.
>So $itemtype->{itemtype} should be passed.
>
>Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>
>Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
>---
> circ/returns.pl | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/circ/returns.pl b/circ/returns.pl
>index ec0679f..637f4b2 100755
>--- a/circ/returns.pl
>+++ b/circ/returns.pl
>@@ -276,7 +276,7 @@ if ($barcode) {
>     }
> 
>     # make sure return branch respects home branch circulation rules, default to homebranch
>-    my $hbr = GetBranchItemRule($biblio->{'homebranch'}, $itemtype)->{'returnbranch'} || "homebranch";
>+    my $hbr = GetBranchItemRule($biblio->{'homebranch'}, $itemtype->{itemtype})->{'returnbranch'} || "homebranch";
>     my $returnbranch = $biblio->{$hbr} ;
> 
>     $template->param(
>-- 
>1.9.1

Actions: View | Diff | Splinter Review

Attachments on bug 14842: 42637 | 42803 | 43035