Attachment 43059 Details for Bug 14942 – Bug 14942: add itemnumber even though there is no barcode

[patch] Bug 14942: add itemnumber even though there is no barcode

Bug-14942-add-itemnumber-even-though-there-is-no-b.patch (text/plain), 2.47 KB, created by Joonas Kylmälä on 2015-10-02 12:25:19 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Joonas Kylmälä

Created: 2015-10-02 12:25:19 UTC

Size: 2.47 KB

patch

obsolete

>From ccd92c776a06a5a21726a488740a12356b15d3fe Mon Sep 17 00:00:00 2001
>From: =?UTF-8?q?Joonas=20Kylm=C3=A4l=C3=A4?= <j.kylmala@gmail.com>
>Date: Fri, 2 Oct 2015 12:09:14 +0000
>Subject: [PATCH] Bug 14942: add itemnumber even though there is no barcode
>
>Adding item number even though there's no barcode makes sure that some holds
>are not missing item number (and some won't have other hold's item numbers)
>and therefore not being changed to biblio level holds.
>
>Test plan:
>1. Have a item level hold entry without a barcode
>2. Add now a new item level hold request through OPAC
>3. Go to edit that new hold request's pickup library through staff side.
>4. Notice that the new hold request is now at biblio level
>5. Apply patch
>6. Do the same steps as before but now notice that the new hold request is
>   still at item level.
>
>Sponsored-by: Vaara-kirjastot
>---
> koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt
>index 9bac8ea..c0f1570 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt
>@@ -695,10 +695,10 @@ function checkMultiHold() {
>           <a href="/cgi-bin/koha/catalogue/detail.pl?biblionumber=[% reserveloo.biblionumber %]">
>                 [% IF ( reserveloo.barcodenumber ) %]
>                     [% reserveloo.barcodenumber %]
>-                    <input type="hidden" name="itemnumber" value="[% reserveloo.itemnumber %]" />
>                 [% ELSE %]
>                     No barcode
>                 [% END %]
>+                <input type="hidden" name="itemnumber" value="[% reserveloo.itemnumber %]" />
>           </a>
>     [% ELSE %]
>       [% IF ( reserveloo.constrainttypea ) %]
>@@ -707,10 +707,10 @@ function checkMultiHold() {
>                 <a href="/cgi-bin/koha/catalogue/detail.pl?biblionumber=[% reserveloo.biblionumber %]">
>                      [% IF ( reserveloo.barcodenumber ) %]
>                          [% reserveloo.barcodenumber %]
>-                        <input type="hidden" name="itemnumber" value="[% reserveloo.itemnumber %]" />
>                     [% ELSE %]
>                         No barcode
>                     [% END %]
>+                    <input type="hidden" name="itemnumber" value="[% reserveloo.itemnumber %]" />
>                 </a>
>                 </i>
>             [% ELSE %]
>-- 
>1.9.1

Actions: View | Diff | Splinter Review

Attachments on bug 14942: 43059 | 53498