Attachment 43079 Details for Bug 14518 – [SIGNED OFF] Bug 14518 - Allow deleting recordss with reservations (and no item) after confirmation

[patch] [SIGNED OFF] Bug 14518 - Allow deleting recordss with reservations (and no item) after confirmation

SIGNED-OFF-Bug-14518---Allow-deleting-notices-with.patch (text/plain), 1.63 KB, created by Nick Clemens (kidclamp) on 2015-10-02 20:56:39 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Nick Clemens (kidclamp)

Created: 2015-10-02 20:56:39 UTC

Size: 1.63 KB

patch

obsolete

>From b83a617ad6f622dbbcd979b1e0130997ff6acb32 Mon Sep 17 00:00:00 2001
>From: remi <remi.mayrand-provencher@inLibro.com>
>Date: Wed, 20 May 2015 13:26:23 -0400
>Subject: [PATCH] [SIGNED OFF] Bug 14518 - Allow deleting notices with
> reservations (and no item) after confirmation
>
>Cleaning up notices with no item but reservation is impossible since the code does not consider
>the result from the confirmation popup.
>
>This situation happens to our client in their (annual) cleanup.  I suppose those are notices
>for orders that never materialized, but people already made reservations on them.
>
>Test:
>1) create (or find) a notice with no item.
>2) make a reservation on it.
>3) try to delete the notice.
>   a) a popup will ask for confirmation
>   b) after accepting, validate if the notice is deleted.
>
>Signed-off-by: Nick Clemens <nick@quecheelibrary.org>
>---
> koha-tmpl/intranet-tmpl/prog/en/includes/cat-toolbar.inc | 4 ----
> 1 file changed, 4 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/cat-toolbar.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/cat-toolbar.inc
>index ee39f31..8f44496 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/includes/cat-toolbar.inc
>+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/cat-toolbar.inc
>@@ -57,11 +57,7 @@
>             is_confirmed = confirm(_("Are you sure you want to delete this record?"));
>         }
>         if (is_confirmed) {
>-            if ( count > 0 || holdcount > 0 ){
>-                return false;
>-            } else {
>                 window.location="/cgi-bin/koha/cataloguing/addbiblio.pl?op=delete&amp;biblionumber=[% biblionumber %]";
>-            }
> 	} else {
>             return false;
> 	}
>-- 
>1.9.1

Actions: View | Diff | Splinter Review

Attachments on bug 14518: 40918 | 43079 | 43082