Attachment 43083 Details for Bug 14528 – [PASSED QA] Bug 14528: Inconsistency in permissions check when listing shelves

[patch] [PASSED QA] Bug 14528: Inconsistency in permissions check when listing shelves

PASSED-QA-Bug-14528-Inconsistency-in-permissions-c.patch (text/plain), 1.25 KB, created by Katrin Fischer on 2015-10-03 20:38:48 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Katrin Fischer

Created: 2015-10-03 20:38:48 UTC

Size: 1.25 KB

patch

obsolete

>From d31500653743e315b30bd16358a5b5fb7c7276e8 Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Tue, 14 Jul 2015 16:44:37 +0100
>Subject: [PATCH] [PASSED QA] Bug 14528: Inconsistency in permissions check
> when listing shelves
>
>The svc script needed borrowers when the shelves.pl needed catalogue.
>There is no sense to have different permissions here.
>
>Test plan:
>1/ Remove the borrowers permission to a user
>2/ Use this user to log in
>3/ Go on the shelf list
>4/ Without this patch, you should get an endless "Processing..." which
>is fixed if you apply it.
>
>Signed-off-by: Nick Clemens <nick@quecheelibrary.org>
>
>Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
>---
> svc/virtualshelves/search | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/svc/virtualshelves/search b/svc/virtualshelves/search
>index ef1448c..5e991fc 100755
>--- a/svc/virtualshelves/search
>+++ b/svc/virtualshelves/search
>@@ -17,7 +17,7 @@ my ($template, $user, $cookie) = get_template_and_user({
>     query           => $input,
>     type            => "intranet",
>     authnotrequired => 0,
>-    flagsrequired   => { borrowers => 1 }
>+    flagsrequired   => { catalogue => 1 }
> });
> 
> my $shelfname = $input->param('shelfname');
>-- 
>1.9.1

Actions: View | Diff | Splinter Review

Attachments on bug 14528: 40995 | 40996 | 41090 | 43083