Bugzilla – Attachment 43085 Details for
Bug 6379
Remove link from unapproved and rejected tags in the OPAC's "My tags" table
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[PASSED QA] Bug 6379: Fix if the reviewer is not the same patron
PASSED-QA-Bug-6379-Fix-if-the-reviewer-is-not-the-.patch (text/plain), 1.19 KB, created by
Katrin Fischer
on 2015-10-03 20:55:50 UTC
(
hide
)
Description:
[PASSED QA] Bug 6379: Fix if the reviewer is not the same patron
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2015-10-03 20:55:50 UTC
Size:
1.19 KB
patch
obsolete
>From 1af485331e14213d9d886b9906d7b261275d8f9e Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Fri, 10 Jul 2015 11:56:14 +0100 >Subject: [PATCH] [PASSED QA] Bug 6379: Fix if the reviewer is not the same > patron > >get_approval_rows does a left join on tags_approval.approved_by = >borrowers.borrowernumber > >This means it cannot return the approval tags for a given patron. > >Note that this patch could be time-consuming if there is a lot of tags >in the DB. > >Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> >--- > opac/opac-tags.pl | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/opac/opac-tags.pl b/opac/opac-tags.pl >index 19994d1..4f97896 100755 >--- a/opac/opac-tags.pl >+++ b/opac/opac-tags.pl >@@ -227,7 +227,7 @@ my $my_tags = []; > > if ($loggedinuser) { > $my_tags = get_tag_rows({borrowernumber=>$loggedinuser}); >- my $my_approved_tags = get_approval_rows({borrowernumber => $loggedinuser, approved => 1}); >+ my $my_approved_tags = get_approval_rows({ approved => 1 }); > foreach my $tag (@$my_tags) { > my $biblio = GetBiblioData($tag->{biblionumber}); > my $record = &GetMarcBiblio( $tag->{biblionumber} ); >-- >1.9.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 6379
:
5266
|
37211
|
37222
|
37259
|
39088
|
40915
|
43084
| 43085