Bugzilla – Attachment 43292 Details for
Bug 14562
[3.18.x] Patron with empty card number will be only result returned by patron datatables search
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 14562: All patrons returned if 1 has a cardnumber set to an empty string (Fix conflict with bug 12833)
Bug-14562-All-patrons-returned-if-1-has-a-cardnumb.patch (text/plain), 1.31 KB, created by
Joonas Kylmälä
on 2015-10-09 09:35:06 UTC
(
hide
)
Description:
Bug 14562: All patrons returned if 1 has a cardnumber set to an empty string (Fix conflict with bug 12833)
Filename:
MIME Type:
Creator:
Joonas Kylmälä
Created:
2015-10-09 09:35:06 UTC
Size:
1.31 KB
patch
obsolete
>From d6efd5bc2fd7b5e683e8debf4b7a87e8049ecaf0 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@biblibre.com> >Date: Wed, 1 Oct 2014 10:46:14 +0200 >Subject: [PATCH] Bug 14562: All patrons returned if 1 has a cardnumber set to > an empty string (Fix conflict with bug 12833) >MIME-Version: 1.0 >Content-Type: text/plain; charset=UTF-8 >Content-Transfer-Encoding: 8bit > >This patch is a backport of (Bug 12648 is in 3.20.x, not 3.18.x): >commit 481479fe627dcbabb3ef66df0724cc3fe75b110c > Bug 12648: Fix conflict with bug 12833 > >Test plan: >Set the cardnumber of one of the patron to an empty string >Do a patron search and use filters >The search will redirect to the patron detail page of the patron with >the empty string > >Signed-off-by: Joonas Kylmälä <j.kylmala@gmail.com> >--- > svc/members/search | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > >diff --git a/svc/members/search b/svc/members/search >index f8c725b..60695ec 100755 >--- a/svc/members/search >+++ b/svc/members/search >@@ -60,7 +60,8 @@ foreach (grep {$_ =~ /^mDataProp/} keys %dt_params) { > my $results; > # If the user filled a term, maybe it's a cardnumber. > # This cannot be the case if a first letter is given. >-if ( not $firstletter >+if ( $searchmember >+ and not $firstletter > and $searchfieldstype > and $searchfieldstype eq 'standard' ) > { >-- >1.9.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 14562
:
41436
|
43292
|
43568