Attachment 43379 Details for Bug 14653 – Bug 14653 - Acq planning export always use default active period

[patch] Bug 14653 - Acq planning export always use default active period

Bug-14653---Acq-planning-export-always-use-default.patch (text/plain), 1.92 KB, created by Jonathan Druart on 2015-10-13 11:30:36 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2015-10-13 11:30:36 UTC

Size: 1.92 KB

patch

obsolete

>From 2ae59f42c1dfe82399d2e370d29388560a108017 Mon Sep 17 00:00:00 2001
>From: Fridolin Somers <fridolin.somers@biblibre.com>
>Date: Thu, 6 Aug 2015 10:49:03 +0200
>Subject: [PATCH] Bug 14653 - Acq planning export always use default active
> period
>
>In Acq planning /cgi-bin/koha/admin/aqplan.pl, left side filter and export forms have no parameter budget_period_id nor authcat, so the use the default active period.
>As said in code
>- IF PERIOD_ID IS DEFINED,  GET THE PERIOD - ELSE GET THE ACTIVE PERIOD BY DEFAULT
>my $period = GetBudgetPeriod($budget_period_id);
>
>This patch corrects the export form.
>
>Test plan :
>- Create an active budget "B_ACTIVE" with 1 fund
>- Create an inactive budget "B_OLD" with 3 funds
>- Go to "B_OLD" planning by libraries
>- You see 3 funds
>- Click on "Submit" in export form
>=> Without patch, you get the planning of "B_ACTIVE" with 1 fund
>=> Without patch, you get the planning of "B_OLD" with 3 funds by libraries
>
>Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com>
>Works as advertised
>
>Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com>
>
>Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>---
> koha-tmpl/intranet-tmpl/prog/en/modules/admin/aqplan.tt | 2 ++
> 1 file changed, 2 insertions(+)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/aqplan.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/aqplan.tt
>index 2b16b64..f391389 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/aqplan.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/aqplan.tt
>@@ -313,6 +313,8 @@
>     <fieldset class="action">    <input type="submit" value="Submit"/>
>     <input type="hidden" name="report_name" value="[% report_name %]" />
>     <input type="hidden" name="output" value="file" /></fieldset>
>+    <input type="hidden" name="budget_period_id" value="[% budget_period_id %]" />
>+    <input type="hidden" name="authcat" value="[% authcat %]" />
>     </fieldset>
> </form>
> [% END %]
>-- 
>2.1.0

Actions: View | Diff | Splinter Review

Attachments on bug 14653: 41399 | 41400 | 43307 | 43308 | 43309 | 43378 | 43379