Bugzilla – Attachment 43523 Details for
Bug 12933
Add ability to print overdue slip from staff intranet
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 12933 [QA Followup] - Rename GetOverdues to GetOverduesForPatron
Bug-12933-QA-Followup---Rename-GetOverdues-to-GetO.patch (text/plain), 2.48 KB, created by
Kyle M Hall (khall)
on 2015-10-16 14:36:30 UTC
(
hide
)
Description:
Bug 12933 [QA Followup] - Rename GetOverdues to GetOverduesForPatron
Filename:
MIME Type:
Creator:
Kyle M Hall (khall)
Created:
2015-10-16 14:36:30 UTC
Size:
2.48 KB
patch
obsolete
>From c04555ddc0749af1ab52b37d7e83d2cc298a8252 Mon Sep 17 00:00:00 2001 >From: Kyle M Hall <kyle@bywatersolutions.com> >Date: Mon, 26 Jan 2015 08:39:17 -0500 >Subject: [PATCH] Bug 12933 [QA Followup] - Rename GetOverdues to GetOverduesForPatron > >--- > C4/Members.pm | 4 ++-- > members/print_overdues.pl | 4 ++-- > t/db_dependent/Members/GetOverdues.t | 4 ++-- > 3 files changed, 6 insertions(+), 6 deletions(-) > >diff --git a/C4/Members.pm b/C4/Members.pm >index 55d4166..9507b9f 100644 >--- a/C4/Members.pm >+++ b/C4/Members.pm >@@ -108,7 +108,7 @@ BEGIN { > GetBorrowersWithEmail > > HasOverdues >- GetOverdues >+ GetOverduesForPatron > ); > > #Modify data >@@ -2553,7 +2553,7 @@ WHERE borrowernumber = 0 AND DATEDIFF( NOW(), timestamp ) > ?|; > return $cnt eq '0E0'? 0: $cnt; > } > >-sub GetOverdues { >+sub GetOverduesForPatron { > my ( $borrowernumber ) = @_; > > my $sql = " >diff --git a/members/print_overdues.pl b/members/print_overdues.pl >index 526f615..b63dec9 100755 >--- a/members/print_overdues.pl >+++ b/members/print_overdues.pl >@@ -24,7 +24,7 @@ use CGI; > use C4::Context; > use C4::Auth; > use C4::Output; >-use C4::Members qw(GetOverdues); >+use C4::Members qw(GetOverduesForPatron); > use C4::Overdues qw(parse_overdues_letter); > > my $input = new CGI; >@@ -45,7 +45,7 @@ my ( $template, $loggedinuser, $cookie ) = get_template_and_user( > my $borrowernumber = $input->param('borrowernumber'); > my $branchcode = C4::Context->userenv->{'branch'}; > >-my $overdues = GetOverdues($borrowernumber); >+my $overdues = GetOverduesForPatron($borrowernumber); > > my $letter = parse_overdues_letter( > { >diff --git a/t/db_dependent/Members/GetOverdues.t b/t/db_dependent/Members/GetOverdues.t >index d779967..c0ae372 100644 >--- a/t/db_dependent/Members/GetOverdues.t >+++ b/t/db_dependent/Members/GetOverdues.t >@@ -57,8 +57,8 @@ AddIssue( $borrower, '0101', DateTime->now->subtract( days => 1 ) ); > AddIssue( $borrower, '0102', DateTime->now->subtract( days => 5 ) ); > AddIssue( $borrower, '0103' ); > >-my $overdues = C4::Members::GetOverdues( $borrowernumber ); >-is( @$overdues, 2, 'GetOverdues returns the correct number of elements' ); >+my $overdues = C4::Members::GetOverduesForPatron( $borrowernumber ); >+is( @$overdues, 2, 'GetOverduesForPatron returns the correct number of elements' ); > is( $overdues->[0]->{itemnumber}, $itemnumber1, 'First overdue is correct' ); > is( $overdues->[1]->{itemnumber}, $itemnumber2, 'Second overdue is correct' ); > >-- >1.7.2.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 12933
:
31638
|
31667
|
34456
|
34457
|
34467
|
34468
|
34469
|
34470
|
34471
|
34474
|
34475
|
34884
|
34885
|
34886
|
34887
|
34888
|
34889
|
35533
|
35534
|
35535
|
35536
|
35537
|
35538
|
35918
|
41606
|
41607
|
41608
|
41609
|
41610
|
41611
|
43514
|
43515
|
43516
|
43517
|
43518
|
43519
|
43520
|
43521
|
43522
|
43523
|
43904
|
43905
|
43906
|
43907
|
43908
|
43925
|
43926
|
43927
|
43928
|
43929
|
43930
|
43953