Attachment 43538 Details for Bug 14247 – Bug 14247: Add system preference for news display

[patch] Bug 14247: Add system preference for news display

Bug-14247-Add-system-preference-for-news-display.patch (text/plain), 2.40 KB, created by Marc Véron on 2015-10-16 18:39:36 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Marc Véron

Created: 2015-10-16 18:39:36 UTC

Size: 2.40 KB

patch

obsolete

>From 6bafdfba7f6893958f89db932c36a91a66d44e41 Mon Sep 17 00:00:00 2001
>From: Martin Persson <xarragon@gmail.com>
>Date: Sun, 4 Oct 2015 15:51:06 +0200
>Subject: [PATCH] Bug 14247: Add system preference for news display
>MIME-Version: 1.0
>Content-Type: text/plain; charset=UTF-8
>Content-Transfer-Encoding: 8bit
>
>Added default value for system preference.
>
>Test plan:
>
>* Apply dependant patch 14246 (if not done already).
>* Apply current patch.
>* Log into the Staff client, go to 'Administration' -> 'Global Preferences' -> 'Tools', a new section titled 'News' should appear with a single option named 'NewsAuthorDisplay'. Available values should be 'Not at all', 'OPAC only', 'Staff client only' and 'Both OPAC and staff client'. By default the value should be 'Not at all' (to mimic existing behaviour, important!).
>* Change the value to something different and save the changes.
>* Use the mysql command line client to connect to the Koha database:
>  $ mysql -u kohaadmin -p -D koha
>* Enter the following query:
>  SELECT * FROM systempreferences WHERE variable = 'NewsAuthorDisplay';
>* Check to make sure that the 'value' column has changed to reflect the choice you made in the above step.
>
>Separate SQL testing (clean installation of Koha):
>* Koha$ mysql -u root < create_koha_test_db.sql
>* Koha$ mysql -u koha_test -D koha_test < installer/data/mysql/kohastructure.sql
>* Koha$ mysql -u koha_test -D koha_test < installer/data/mysql/sysprefs.sql
>
>Testing the update script works the same way:
>* Koha$ echo "DELETE FROM systempreferences WHERE variable = 'NewsAuthorDisplay';" | mysql -u koha_test -D koha_test
>* Koha$ mysql -u koha_test -D koha_test < installer/data/mysql/atomicupdate/add_news_prefs.sql
>
>Signed-off-by: Marc VÃ©ron <veron@veron.ch>
>---
> koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/tools.pref |    1 +
> 1 file changed, 1 insertion(+)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/tools.pref b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/tools.pref
>index 5a3ddce..a075ce7 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/tools.pref
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/tools.pref
>@@ -15,6 +15,7 @@ Tools:
>         -
>             - "Show the author for news items:"
>             - pref: NewsAuthorDisplay
>+              default: none
>               choices:
>                   none: "Not at all"
>                   opac: "OPAC only"
>-- 
>1.7.10.4

Actions: View | Diff | Splinter Review

Attachments on bug 14247: 39362 | 39414 | 39418 | 39440 | 39488 | 39527 | 43093 | 43538 | 43539 | 43540 | 43541 | 43542 | 43543 | 43724 | 43725 | 43914 | 43915