Attachment 43568 Details for Bug 14562 – [PASSED QA] Bug 14562: All patrons returned if 1 has a cardnumber set to an empty string (Fix conflict with bug 12833)

[patch] [PASSED QA] Bug 14562: All patrons returned if 1 has a cardnumber set to an empty string (Fix conflict with bug 12833)

PASSED-QA-Bug-14562-All-patrons-returned-if-1-has-.patch (text/plain), 1.38 KB, created by Katrin Fischer on 2015-10-18 11:03:32 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Katrin Fischer

Created: 2015-10-18 11:03:32 UTC

Size: 1.38 KB

patch

obsolete

>From 5cbe0d105a740f24ad4d4aeb5f132dbb65f46268 Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@biblibre.com>
>Date: Wed, 1 Oct 2014 10:46:14 +0200
>Subject: [PATCH] [PASSED QA] Bug 14562: All patrons returned if 1 has a
> cardnumber set to an empty string (Fix conflict with bug 12833)
>MIME-Version: 1.0
>Content-Type: text/plain; charset=UTF-8
>Content-Transfer-Encoding: 8bit
>
>This patch is a backport of (Bug 12648 is in 3.20.x, not 3.18.x):
>commit 481479fe627dcbabb3ef66df0724cc3fe75b110c
>    Bug 12648: Fix conflict with bug 12833
>
>Test plan:
>Set the cardnumber of one of the patron to an empty string
>Do a patron search and use filters
>The search will redirect to the patron detail page of the patron with
>the empty string
>
>Signed-off-by: Joonas KylmÃ¤lÃ¤ <j.kylmala@gmail.com>
>
>Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
>---
> svc/members/search | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
>diff --git a/svc/members/search b/svc/members/search
>index f8c725b..60695ec 100755
>--- a/svc/members/search
>+++ b/svc/members/search
>@@ -60,7 +60,8 @@ foreach (grep {$_ =~ /^mDataProp/} keys %dt_params) {
> my $results;
> # If the user filled a term, maybe it's a cardnumber.
> # This cannot be the case if a first letter is given.
>-if (    not $firstletter
>+if ( $searchmember
>+    and not $firstletter
>     and $searchfieldstype
>     and $searchfieldstype eq 'standard' )
> {
>-- 
>1.9.1

Actions: View | Diff | Splinter Review

Attachments on bug 14562: 41436 | 43292 | 43568