Bugzilla – Attachment 43617 Details for
Bug 11559
Professional cataloger's interface
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 11559: (followup) Fix keyboard control bugs, make labels clickable
Bug-11559-followup-Fix-keyboard-control-bugs-make-.patch (text/plain), 5.31 KB, created by
Jesse Weaver
on 2015-10-19 23:49:27 UTC
(
hide
)
Description:
Bug 11559: (followup) Fix keyboard control bugs, make labels clickable
Filename:
MIME Type:
Creator:
Jesse Weaver
Created:
2015-10-19 23:49:27 UTC
Size:
5.31 KB
patch
obsolete
>From ef8e2f06d21c8bfae4cd1b170b54ba2f6bf5103a Mon Sep 17 00:00:00 2001 >From: Jesse Weaver <pianohacker@gmail.com> >Date: Tue, 23 Jun 2015 16:24:17 -0600 >Subject: [PATCH] Bug 11559: (followup) Fix keyboard control bugs, make labels > clickable > >This fixes the following issues: > * Labels of search server checkboxes cannot be clicked > * Quick search fields cannot be focused > * Search results cannot be scrolled with a keyboard >--- > .../intranet-tmpl/prog/en/includes/cateditor-ui.inc | 17 +++++++++-------- > .../intranet-tmpl/prog/en/modules/cataloguing/editor.tt | 3 ++- > 2 files changed, 11 insertions(+), 9 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/cateditor-ui.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/cateditor-ui.inc >index 89a11ec..f6975ba 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/cateditor-ui.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/cateditor-ui.inc >@@ -105,25 +105,25 @@ require( [ 'koha-backend', 'search', 'macros', 'marc-editor', 'marc-record', 'pr > } ); > > shortcut.add( 'alt+ctrl+k', function(event) { >- if ( Search.IsAvailable() ) $( '#search-by-keywords' ).focus(); >+ $( '#search-by-keywords' ).focus(); > > return false; > } ); > > shortcut.add( 'alt+ctrl+a', function(event) { >- if ( Search.IsAvailable() ) $( '#search-by-author' ).focus(); >+ $( '#search-by-author' ).focus(); > > return false; > } ); > > shortcut.add( 'alt+ctrl+i', function(event) { >- if ( Search.IsAvailable() ) $( '#search-by-isbn' ).focus(); >+ $( '#search-by-isbn' ).focus(); > > return false; > } ); > > shortcut.add( 'alt+ctrl+t', function(event) { >- if ( Search.IsAvailable() ) $( '#search-by-title' ).focus(); >+ $( '#search-by-title' ).focus(); > > return false; > } ); >@@ -351,7 +351,7 @@ require( [ 'koha-backend', 'search', 'macros', 'marc-editor', 'marc-record', 'pr > function showAdvancedSearch() { > $('#advanced-search-servers').empty(); > $.each( z3950Servers, function( server_id, server ) { >- $('#advanced-search-servers').append( '<li data-server-id="' + server_id + '"><input class="search-toggle-server" type="checkbox"' + ( server.checked ? ' checked="checked">' : '>' ) + server.name + '</li>' ); >+ $('#advanced-search-servers').append( '<li data-server-id="' + server_id + '"><label><input class="search-toggle-server" type="checkbox"' + ( server.checked ? ' checked="checked">' : '>' ) + server.name + '</label></li>' ); > } ); > $('#advanced-search-ui').modal('show'); > } >@@ -413,7 +413,7 @@ require( [ 'koha-backend', 'search', 'macros', 'marc-editor', 'marc-record', 'pr > num_fetched += '+'; > } > >- $('#search-serversinfo').append( '<li data-server-id="' + server_id + '"><input class="search-toggle-server" type="checkbox"' + ( server.checked ? ' checked="checked">' : '>' ) + server.name + ' (' + num_fetched + ')' + '</li>' ); >+ $('#search-serversinfo').append( '<li data-server-id="' + server_id + '"><label><input class="search-toggle-server" type="checkbox"' + ( server.checked ? ' checked="checked">' : '>' ) + server.name + ' (' + num_fetched + ')' + '</label></li>' ); > } ); > > var seenColumns = {}; >@@ -527,6 +527,7 @@ require( [ 'koha-backend', 'search', 'macros', 'marc-editor', 'marc-record', 'pr > } else { > $overlay.find('.bar').css( { display: 'block', width: '100%' } ); > $overlay.fadeOut(); >+ $('#searchresults')[0].focus(); > } > } > >@@ -607,7 +608,7 @@ require( [ 'koha-backend', 'search', 'macros', 'marc-editor', 'marc-record', 'pr > break; > case 'selected_search_targets': > $( document ).on( 'change', 'input.search-toggle-server', function() { >- var server_id = $( this ).parent().data('server-id'); >+ var server_id = $( this ).closest('li').data('server-id'); > Preferences.user.selected_search_targets[server_id] = this.checked; > Preferences.Save( [% USER_INFO.0.borrowernumber %] ); > } ); >@@ -974,7 +975,7 @@ require( [ 'koha-backend', 'search', 'macros', 'marc-editor', 'marc-record', 'pr > }); > > $( document ).on( 'change', 'input.search-toggle-server', function() { >- var server = z3950Servers[ $( this ).parent().data('server-id') ]; >+ var server = z3950Servers[ $( this ).closest('li').data('server-id') ]; > server.checked = this.checked; > > if ( $('#search-results-ui').is( ':visible' ) ) { >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/editor.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/editor.tt >index 0991dde..4e2bbdf 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/editor.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/editor.tt >@@ -184,7 +184,8 @@ > </div> > </div> > <div class="span9"> >- <div id="searchresults"> >+ <!-- tabindex attribute allows JS-controlled focus --> >+ <div id="searchresults" tabindex="-1"> > <div id="search-top-pages"> > <div class="pagination pagination-small"> > </div> >-- >2.6.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 11559
:
26069
|
26070
|
26071
|
26104
|
26653
|
26654
|
27140
|
27141
|
27142
|
27757
|
27758
|
27759
|
27760
|
27761
|
27900
|
27901
|
27902
|
27993
|
27995
|
34458
|
34459
|
34460
|
34461
|
34462
|
34463
|
36243
|
36244
|
36245
|
36246
|
36247
|
36248
|
36455
|
38533
|
38534
|
38535
|
38536
|
38537
|
38538
|
38539
|
40153
|
40154
|
40155
|
40543
|
40555
|
40556
|
40557
|
40558
|
40811
|
40812
|
40813
|
40814
|
40815
|
41425
|
41453
|
41476
|
42373
|
43261
|
43547
|
43614
|
43615
|
43616
|
43617
|
43618
|
43619
|
43620
|
43621
|
43622
|
43623
|
43703
|
43704
|
43705
|
43706
|
43707
|
43708
|
43709
|
43710
|
43711
|
43712
|
43713
|
43772
|
43790
|
43883
|
43969
|
44016
|
44018
|
44022
|
44023
|
44024
|
44025
|
44026
|
44027
|
44028
|
44029
|
44030
|
44031
|
44032
|
44033
|
44034
|
44035
|
44036