Attachment 43641 Details for Bug 14778 – Bug 14778: Install fixtures for t/Members_AttributeTypes.t

[patch] Bug 14778: Install fixtures for t/Members_AttributeTypes.t

Bug-14778-Install-fixtures-for-tMembersAttributeTy.patch (text/plain), 2.98 KB, created by Jonathan Druart on 2015-10-20 15:02:28 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2015-10-20 15:02:28 UTC

Size: 2.98 KB

patch

obsolete

>From 7431adb972c226c3908dbb93b8a89c71ecbb5fb2 Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Tue, 20 Oct 2015 14:10:18 +0100
>Subject: [PATCH] Bug 14778: Install fixtures for t/Members_AttributeTypes.t
>
>---
> t/Members_AttributeTypes.t | 43 +++++++++++++++++++++----------------------
> 1 file changed, 21 insertions(+), 22 deletions(-)
>
>diff --git a/t/Members_AttributeTypes.t b/t/Members_AttributeTypes.t
>index 152fc53..055e767 100755
>--- a/t/Members_AttributeTypes.t
>+++ b/t/Members_AttributeTypes.t
>@@ -2,40 +2,43 @@
> #
> # Tests 'fetch', 'fake db data', and 'checks for existant attributes'
> 
>-use strict;
>-use warnings;
>+use Modern::Perl;
> use Test::MockModule;
>-use Test::More tests => 9;
>+use Test::More tests => 10;
> 
> BEGIN {
>     use_ok('C4::Members::AttributeTypes');
> }
> 
>-my $module = new Test::MockModule('C4::Context');
>-$module->mock(
>-    '_new_dbh',
>-    sub {
>-        my $dbh = DBI->connect( 'DBI:Mock:', '', '' )
>-          || die "Cannot create handle: $DBI::errstr\n";
>-        return $dbh;
>-    }
>-);
>-my $members_attributetypes = [
>+use Test::DBIx::Class {
>+    schema_class => 'Koha::Schema',
>+    connect_info => ['dbi:SQLite:dbname=:memory:','',''],
>+    connect_opts => { name_sep => '.', quote_char => '`', },
>+    fixture_class => '::Populate',
>+}, 'BorrowerAttributeType', 'Category' ;
>+
>+fixtures_ok [
>+    Category => [
>+        ['categorycode'],
>+        ['orange'], ['yellow'],
>+    ],
>+    BorrowerAttributeType => [
>     [
>         'code',             'description',
>         'repeatable',       'unique_id',
>         'opac_display',     'password_allowed',
>         'staff_searchable', 'authorised_value_category',
>-        'display_checkout', 'catagory_code',
>+        'display_checkout', 'category_code',
>         'class'
>     ],
>     [ 'one', 'ISBN', '1', '1', '1', '1', '1', 'red',  '1', 'orange', 'green' ],
>     [ 'two', 'ISSN', '0', '0', '0', '0', '0', 'blue', '0', 'yellow', 'silver' ]
>-];
> 
>-my $dbh = C4::Context->dbh();
>+    ],
>+], 'add fixtures';
> 
>-$dbh->{mock_add_resultset} = $members_attributetypes;
>+my $db = Test::MockModule->new('Koha::Database');
>+$db->mock( _new_schema => sub { return Schema(); } );
> 
> my @members_attributetypes = C4::Members::AttributeTypes::GetAttributeTypes(undef, 1);
> 
>@@ -49,8 +52,6 @@ is( $members_attributetypes[0]->{'class'},
> is( $members_attributetypes[1]->{'class'},
>     'silver', 'Second class value is silver' );
> 
>-$dbh->{mock_add_resultset} = $members_attributetypes;
>-
> ok( C4::Members::AttributeTypes::AttributeTypeExists('one'),
>     'checking an attribute type exists' );
> 
>@@ -59,9 +60,7 @@ ok(
>     "checking a attribute that isn't in the code doesn't exist"
> );
> 
>-$dbh->{mock_add_resultset} = $members_attributetypes;
>-
>-ok( C4::Members::AttributeTypes->fetch('ISBN'), "testing fetch feature" );
>+ok( C4::Members::AttributeTypes->fetch('one'), "testing fetch feature" );
> 
> ok( !C4::Members::AttributeTypes->fetch('FAKE'),
>     "testing fetch feature doesn't work if value not in database" );
>-- 
>2.1.0

Actions: View | Diff | Splinter Review

Attachments on bug 14778: 42326 | 42388 | 43247 | 43248 | 43249 | 43250 | 43440 | 43631 | 43632 | 43633 | 43634 | 43635 | 43636 | 43637 | 43638 | 43639 | 43640 | 43641 | 43642 | 43643 | 43644 | 43645 | 43834 | 43835 | 43836 | 43837 | 43838 | 43839 | 43840 | 43841 | 43842 | 43843 | 43844 | 43845 | 43846 | 43847 | 43848 | 43849 | 43850 | 43851 | 43852 | 43853 | 43857 | 43858 | 43859 | 43860 | 43861 | 43862 | 43863 | 43864 | 43865 | 43866 | 43867 | 43868 | 43869 | 43870 | 43871 | 43872 | 43873 | 43874 | 43875 | 43876 | 44003