Attachment 43650 Details for Bug 8436 – Bug 8436: QA Follow-up: Add Library to result list

[patch] Bug 8436: QA Follow-up: Add Library to result list

Bug-8436-QA-Follow-up-Add-Library-to-result-list.patch (text/plain), 2.55 KB, created by Katrin Fischer on 2015-10-20 15:05:03 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Katrin Fischer

Created: 2015-10-20 15:05:03 UTC

Size: 2.55 KB

patch

obsolete

>From 1d180677bbb4bb7e1634c29176f8ac08c7c3b09e Mon Sep 17 00:00:00 2001
>From: Katrin Fischer <Katrin.Fischer.83@web.de>
>Date: Tue, 20 Oct 2015 16:46:15 +0200
>Subject: [PATCH] Bug 8436: QA Follow-up: Add Library to result list
>
>If we offer a library filter, we should also show the
>library in the result list, so that search options
>and result list match.
>
>Otherwise, for libraries with multiple branches, there
>is no way to see, which is the subscription of a
>specific branch in the list.
>
>- Add a Library column in the result list
>- Rename branch to library in the template
>---
> .../intranet-tmpl/prog/en/modules/serials/checkexpiration.tt     | 9 +++++++--
> 1 file changed, 7 insertions(+), 2 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/checkexpiration.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/checkexpiration.tt
>index 1859faf..551338a 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/checkexpiration.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/checkexpiration.tt
>@@ -2,6 +2,7 @@
> <title>Koha &rsaquo; Serials &rsaquo; Check expiration</title>
> [% INCLUDE 'doc-head-close.inc' %]
> [% INCLUDE 'calendar.inc' %]
>+[% USE Branches %]
> <script type="text/javascript" language="JavaScript">
> // <![CDATA[
>     /**
>@@ -43,7 +44,7 @@
> 
>     <form name="f" action="/cgi-bin/koha/serials/checkexpiration.pl" method="post" onsubmit="return CheckForm(this);">
> <fieldset class="rows">
>-    <legend>Filter results :</legend>
>+    <legend>Filter results:</legend>
>     
>          <ol>
>         <li><label for="title">Title:</label>
>@@ -52,7 +53,7 @@
>         <li><label for="issn">ISSN:</label>
>         <input id="issn" type="text" name="issn" size="15" value="[% issn %]" /></li>
>         [% IF (branches_loop.size) %]
>-        <li><label for="branch">Branch:</label>
>+        <li><label for="branch">Library:</label>
>         <select id="branch" name="branch">
>             <option value="">All</option>
>             [% FOREACH branch IN branches_loop %]
>@@ -94,6 +95,7 @@
>         <tr>
>             <th>ISSN</th>
>             <th>Title</th>
>+            [% IF ( branches_loop.size ) %]<th>Library</th>[% END %]
>             <th>OPAC note</th>
>             <th>Nonpublic note</th>
>             <th>Expiration date</th>
>@@ -115,6 +117,9 @@
>                 [% END %]
>                 </a>
>             </td>
>+            [% IF ( branches_loop.size ) %]<td>
>+                [% Branches.GetName( subscriptions_loo.branchcode ) %]
>+            </td>[% END %]
>             <td>
>                 [% subscriptions_loo.notes %]
>             </td>
>-- 
>1.9.1

Actions: View | Diff | Splinter Review

Attachments on bug 8436: 11742 | 11746 | 19262 | 35166 | 36062 | 41891 | 43646 | 43647 | 43648 | 43649 | 43650 | 43750 | 43751