Bugzilla – Attachment 43702 Details for
Bug 15037
Batch checkout tab should be hidden for patrons not satisfying policy
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 15037: Correctly check the patron categories on displaying the Batch checkout tab
Bug-15037-Correctly-check-the-patron-categories-on.patch (text/plain), 2.09 KB, created by
Tomás Cohen Arazi (tcohen)
on 2015-10-21 20:31:47 UTC
(
hide
)
Description:
Bug 15037: Correctly check the patron categories on displaying the Batch checkout tab
Filename:
MIME Type:
Creator:
Tomás Cohen Arazi (tcohen)
Created:
2015-10-21 20:31:47 UTC
Size:
2.09 KB
patch
obsolete
>From e9b1f3273e0a0b2423413e3968c089a7440fcfab Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Wed, 21 Oct 2015 14:08:05 +0100 >Subject: [PATCH] Bug 15037: Correctly check the patron categories on > displaying the Batch checkout tab > >When checking for the patron categories allowed to use the batch >checkout, the comparison should be strict (eq). > >Test plan: >0/ Do not apply this patch >1/ Create 2 patron categories ST and S >2/ Enable BatchCheckouts and define BatchCheckoutsValidCategories = S >3/ Create 2 patrons, 1 in the ST category and the other one in S >4/ On the patron detail page, you should see the "batch checkout" tab >for both patron >5/ Apply this patch >6/ The tab should only be displayed for the patron S > >Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> >Tested using an 'S' patron and allowing 'ST' patrons only, worked as expected. >Also tried setting &batch=1 to force it to show the batch page, and it says >I'm not allowed to do batch checkouts for that patron. Great! >--- > koha-tmpl/intranet-tmpl/prog/en/includes/circ-menu.inc | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/circ-menu.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/circ-menu.inc >index 8c058f1..9137efb 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/circ-menu.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/circ-menu.inc >@@ -65,7 +65,7 @@ > <ul> > [% IF ( circview ) %]<li class="active">[% ELSE %]<li>[% END %]<a href="/cgi-bin/koha/circ/circulation.pl?borrowernumber=[% borrowernumber %]">Check out</a></li> > [% IF Koha.Preference('BatchCheckouts') && >- Koha.Preference('BatchCheckoutsValidCategories').split('\|').grep(categorycode).size > 0 %] >+ Koha.Preference('BatchCheckoutsValidCategories').split('\|').grep('^' _ categorycode _ '$').size > 0 %] > [% IF ( batch_checkout_view ) %]<li class="active">[% ELSE %]<li>[% END %]<a href="/cgi-bin/koha/circ/circulation.pl?borrowernumber=[% borrowernumber %]&batch=1">Batch check out</a></li> > [% END %] > [% IF ( CAN_user_borrowers ) %] >-- >2.6.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 15037
:
43692
|
43702
|
43815
|
43816