Bugzilla – Attachment 43764 Details for
Bug 11431
Custom notification sounds
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 11431 [QA Followup] - Hard code list of sounds for security
Bug-11431-QA-Followup---Hard-code-list-of-sounds-f.patch (text/plain), 3.29 KB, created by
Kyle M Hall (khall)
on 2015-10-22 12:45:15 UTC
(
hide
)
Description:
Bug 11431 [QA Followup] - Hard code list of sounds for security
Filename:
MIME Type:
Creator:
Kyle M Hall (khall)
Created:
2015-10-22 12:45:15 UTC
Size:
3.29 KB
patch
obsolete
>From d7565a1f2cbb3b39972549c829e48a93d686720f Mon Sep 17 00:00:00 2001 >From: Kyle M Hall <kyle@bywatersolutions.com> >Date: Thu, 17 Sep 2015 11:04:09 -0400 >Subject: [PATCH] Bug 11431 [QA Followup] - Hard code list of sounds for security > >The sounds directory is no longer available for listing for security. >It is better and safer to hard code the list of sounds. >--- > .../prog/en/modules/admin/audio_alerts.tt | 31 +++++++++++-------- > 1 files changed, 18 insertions(+), 13 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/audio_alerts.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/audio_alerts.tt >index d3471ce..82b3b87 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/audio_alerts.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/audio_alerts.tt >@@ -4,19 +4,6 @@ > > <script type="text/javascript"> > $( document ).ready(function() { >- $.ajax({ >- //This will retrieve the contents of the folder if the folder is configured as 'browsable' >- url: AUDIO_ALERT_PATH, >- success: function (data) { >- $("#fileNames").html('<ul>'); >- //List all png or jpg or gif file names in the page >- $(data).find('a:contains("ogg")').each(function () { >- var filename = this.href.split('/').pop(); >- $('#koha-sounds').append($('<option>', { value : filename }).text(filename)); >- }); >- } >- }); >- > $('#koha-sounds').on('change', function() { > $('#sound').val( this.value ); > }); >@@ -72,6 +59,24 @@ $( document ).ready(function() { > > <select id="koha-sounds"> > <option value="">Select built-in sound</option> >+ <option value="beep.ogg">beep.ogg</option> >+ <option value="call.ogg">call.ogg</option> >+ <option value="critical.ogg">critical.ogg</option> >+ <option value="device_connect.ogg">device_connect.ogg</option> >+ <option value="device_disconnect.ogg">device_disconnect.ogg</option> >+ <option value="ending.ogg">ending.ogg</option> >+ <option value="fail.ogg">fail.ogg</option> >+ <option value="IM_notification.ogg">IM_notification.ogg</option> >+ <option value="incoming_call.ogg">incoming_call.ogg</option> >+ <option value="loading.ogg">loading.ogg</option> >+ <option value="loading_2.ogg">loading_2.ogg</option> >+ <option value="maximize.ogg">maximize.ogg</option> >+ <option value="minimize.ogg">minimize.ogg</option> >+ <option value="new_mail_notification.ogg">new_mail_notification.ogg</option> >+ <option value="opening.ogg">opening.ogg</option> >+ <option value="panic.ogg">panic.ogg</option> >+ <option value="popup.ogg">popup.ogg</option> >+ <option value="warning.ogg">warning.ogg</option> > </select> > > <button id="save-alert" type="submit" class="btn"><i class="icon-hdd"></i> Save alert</button> >-- >1.7.2.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 11431
:
29030
|
29031
|
29032
|
29033
|
29034
|
29035
|
29036
|
29037
|
29038
|
29039
|
29119
|
29120
|
29404
|
29764
|
29765
|
29766
|
29767
|
29768
|
29769
|
31145
|
31146
|
31147
|
31148
|
31149
|
31150
|
34637
|
34638
|
34639
|
34640
|
34641
|
34642
|
34643
|
34644
|
34645
|
34646
|
34647
|
34648
|
34649
|
34650
|
34651
|
34652
|
34653
|
34717
|
34718
|
34719
|
34720
|
34864
|
34865
|
34866
|
34867
|
35843
|
35844
|
35845
|
35846
|
38547
|
38548
|
40726
|
40727
|
40728
|
40729
|
40730
|
40731
|
40732
|
41634
|
41661
|
41662
|
42678
|
42679
|
42680
|
42681
|
42682
|
42683
|
42684
|
42685
|
42686
|
42687
|
42688
|
42689
|
42696
|
43753
|
43754
|
43755
|
43756
|
43757
|
43758
|
43759
|
43760
|
43761
|
43762
|
43763
|
43764
|
43765
|
43817
|
43820
|
43821
|
43822
|
43823
|
43824
|
43825
|
43887
|
43888
|
43889
|
43890
|
43891
|
43892
|
43893
|
43894
|
43895
|
43896
|
43897
|
43898
|
43899
|
43900
|
43901
|
43902
|
43903
|
44391
|
44392
|
44393
|
44394
|
44395
|
44396
|
44397
|
44398
|
44399
|
44400
|
44401
|
44402
|
44404
|
44405
|
44407
|
44408
|
44409
|
44411
|
44412
|
44599
|
45135