Attachment 43804 Details for Bug 14776 – Bug 14776 - Remove 'selfcheck' patron related links from and add language selector to SCO header

[patch] Bug 14776 - Remove 'selfcheck' patron related links from and add language selector to SCO header

Bug-14776---Remove-selfcheck-patron-related-links-.patch (text/plain), 3.17 KB, created by Jonathan Druart on 2015-10-23 08:06:46 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2015-10-23 08:06:46 UTC

Size: 3.17 KB

patch

obsolete

>From 165109962c59b1d218fb23b741adca56940221a5 Mon Sep 17 00:00:00 2001
>From: =?UTF-8?q?Marc=20V=C3=A9ron?= <veron@veron.ch>
>Date: Tue, 20 Oct 2015 18:53:12 +0200
>Subject: [PATCH] Bug 14776 - Remove 'selfcheck' patron related links from and
> add language selector to SCO header
>
>The SCO screen displays patron related menu items in it's header (Link to the account and "Logout").
>This makes no sense since the patron that is logged in is the 'selfcheck' user as defined in syspref AutoSelfCheckId.
>Additionally, the language menue is missing when the syspref OpacLangSelectorMode is set to 'top' or to 'both'.
>
>To test:
>- Apply on top of Bug 15039
>- Set AutoSelfCheck sysprefs as appropriate
>- Set OpacLangSelectorMode to 'top' or 'both'
>- Go to SCO page
>- Verify that the language menue does not display in the header
>- Enter a card number to check out (this logs in the SCO user)
>- Verify that you get text similar to "Welcome, checkout" with a link to the sco user's account in the OPAC and a 'Logout' link
>- Apply patch
>- Verify that the language menu appears and the SCO user's information disappears.
>- Verify, that the language menu displays / does not display with combinations of:
>  - opaclanguagedisplay (Allow)
>  - opaclanguages ( > 1 language selected)
>  - OpacLangSelectorMode (top or both)
>
>Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>---
> koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead-sco.inc | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
>diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead-sco.inc b/koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead-sco.inc
>index e7f8059..e2d707b 100644
>--- a/koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead-sco.inc
>+++ b/koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead-sco.inc
>@@ -1,3 +1,5 @@
>+[% USE Koha %]
>+[% SET OpacLangSelectorMode = Koha.Preference('OpacLangSelectorMode') %]
> <div id="wrap">
>     <div class="navbar navbar-inverse navbar-static-top">
>         <div class="navbar-inner">
>@@ -9,15 +11,13 @@
>                     </ul>
>                 </div>
> 
>-                [% IF ( validuser ) %]
>+                [% IF ( opaclanguagesdisplay ) %]
>                     <div id="members">
>                         <ul class="nav pull-right">
>-                            <li><p class="members navbar-text">Welcome, <a href="/cgi-bin/koha/opac-user.pl"><span class="loggedinusername">[% FOREACH USER_INF IN USER_INFO %][% USER_INF.title %] [% USER_INF.firstname %] [% USER_INF.surname %][% END %]</span></a></p></li>
>-                            <li class="divider-vertical"></li>
>-                            <li><p class="navbar-text">[% IF persona %]<a class="logout" id="logout" href="/cgi-bin/koha/opac-main.pl?logout.x=1" onclick='navigator.id.logout();'>[% ELSE %]<a class="logout" id="logout" href="/cgi-bin/koha/opac-main.pl?logout.x=1">[% END %]Log out</a></p></li>
>+                            [% INCLUDE 'masthead-langmenu.inc' %]
>                         </ul>
>                     </div> 
>-                [% END # / IF validuser %]
>+                [% END # / IF opaclanguagedisplay %]
> 
>             </div> 
>         </div> 
>-- 
>2.1.0

Actions: View | Diff | Splinter Review

Attachments on bug 14776: 42311 | 42423 | 43659 | 43804