Attachment 43833 Details for Bug 12803 – Bug 12803 [QA Followup] - Fix unit tests

[patch] Bug 12803 [QA Followup] - Fix unit tests

Bug-12803-QA-Followup---Fix-unit-tests.patch (text/plain), 2.00 KB, created by Kyle M Hall (khall) on 2015-10-23 13:54:35 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Kyle M Hall (khall)

Created: 2015-10-23 13:54:35 UTC

Size: 2.00 KB

patch

obsolete

>From 0311528839ba43ab30ec00cadf2614ab34683e63 Mon Sep 17 00:00:00 2001
>From: Kyle M Hall <kyle@bywatersolutions.com>
>Date: Fri, 23 Oct 2015 09:53:59 -0400
>Subject: [PATCH] Bug 12803 [QA Followup] - Fix unit tests
>
>---
> t/db_dependent/HoldsQueue.t |   16 +++++++++++++---
> 1 files changed, 13 insertions(+), 3 deletions(-)
>
>diff --git a/t/db_dependent/HoldsQueue.t b/t/db_dependent/HoldsQueue.t
>index 1fcbf6f..de331d4 100755
>--- a/t/db_dependent/HoldsQueue.t
>+++ b/t/db_dependent/HoldsQueue.t
>@@ -30,6 +30,19 @@ my $dbh = C4::Context->dbh;
> $dbh->{AutoCommit} = 0;
> $dbh->{RaiseError} = 1;
> 
>+$dbh->do("DELETE FROM reserves");
>+$dbh->do("DELETE FROM issues");
>+$dbh->do("DELETE FROM items");
>+$dbh->do("DELETE FROM biblio");
>+$dbh->do("DELETE FROM biblioitems");
>+$dbh->do("DELETE FROM transport_cost");
>+$dbh->do("DELETE FROM tmp_holdsqueue");
>+$dbh->do("DELETE FROM hold_fill_targets");
>+$dbh->do("DELETE FROM default_branch_circ_rules");
>+$dbh->do("DELETE FROM default_branch_item_rules");
>+$dbh->do("DELETE FROM default_circ_rules");
>+$dbh->do("DELETE FROM branch_item_rules");
>+
> my $TITLE = "Test Holds Queue XXX";
> 
> my %data = (
>@@ -59,7 +72,6 @@ $dbh->do("UPDATE systempreferences SET value = ? WHERE variable = 'StaticHoldsQu
>          join( ',', @other_branches, $borrower_branchcode, $least_cost_branch_code));
> $dbh->do("UPDATE systempreferences SET value = '0' WHERE variable = 'RandomizeHoldsQueueWeight'");
> 
>-$dbh->do("DELETE FROM transport_cost");
> my $transport_cost_insert_sth = $dbh->prepare("insert into transport_cost (frombranch, tobranch, cost) values (?, ?, ?)");
> # Favour $least_cost_branch_code
> $transport_cost_insert_sth->execute($borrower_branchcode, $least_cost_branch_code, 0.2);
>@@ -93,8 +105,6 @@ foreach ( $borrower_branchcode, $least_cost_branch_code, @other_branches ) {
>     $items_insert_sth->execute($barcode++, $_, $borrower_branchcode);
> }
> 
>-# Remove existing reserves, makes debugging easier
>-$dbh->do("DELETE FROM reserves");
> my $bibitems = undef;
> my $priority = 1;
> # Make a reserve
>-- 
>1.7.2.5

Actions: View | Diff | Splinter Review

Attachments on bug 12803: 31057 | 31060 | 31061 | 31062 | 31063 | 31630 | 31631 | 32046 | 32271 | 43509 | 43510 | 43511 | 43512 | 43610 | 43779 | 43833 | 43979 | 45569 | 45570 | 45571 | 45572 | 45573 | 45574 | 45575 | 45576 | 45638 | 45643 | 45644 | 46888 | 46889 | 46890 | 46891 | 46892 | 46893 | 46894 | 46895 | 47246 | 47247 | 48574 | 48575