Bugzilla – Attachment 43847 Details for
Bug 14778
DBIC should create/own the DB handler
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 14778: Install fixtures for t/Letters.t
Bug-14778-Install-fixtures-for-tLetterst.patch (text/plain), 1.98 KB, created by
Martin Renvoize (ashimema)
on 2015-10-23 14:08:21 UTC
(
hide
)
Description:
Bug 14778: Install fixtures for t/Letters.t
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2015-10-23 14:08:21 UTC
Size:
1.98 KB
patch
obsolete
>From 0a9dd00e91e654a7b0a984bf47eb1c86c46afe0f Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Tue, 20 Oct 2015 13:46:46 +0100 >Subject: [PATCH] Bug 14778: Install fixtures for t/Letters.t > >Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> >--- > t/Letters.t | 36 ++++++++++++++++++------------------ > 1 file changed, 18 insertions(+), 18 deletions(-) > >diff --git a/t/Letters.t b/t/Letters.t >index 4a088da..ad70026 100755 >--- a/t/Letters.t >+++ b/t/Letters.t >@@ -19,28 +19,28 @@ use Modern::Perl; > > use DBI; > use Test::MockModule; >-use Test::More tests => 5; >+use Test::More tests => 6; >+ >+use Test::DBIx::Class { >+ schema_class => 'Koha::Schema', >+ connect_info => ['dbi:SQLite:dbname=:memory:','',''], >+ connect_opts => { name_sep => '.', quote_char => '`', }, >+ fixture_class => '::Populate', >+}, 'Letter' ; > use t::lib::Mocks; >-my $module = new Test::MockModule('C4::Context'); >-$module->mock( >- '_new_dbh', >- sub { >- my $dbh = DBI->connect( 'DBI:Mock:', '', '' ) >- || die "Cannot create handle: $DBI::errstr\n"; >- return $dbh; >- } >-); >-my $mock_letters = [ >- [ 'module', 'code', 'branchcode', 'name', 'is_html', 'title', 'content' ], >- [ 'blah', 'ISBN', 'NBSI', 'book', 1, 'green', 'blahblah' ], >- [ 'bleh', 'ISSN', 'NSSI', 'page', 0, 'blue', 'blehbleh' ] >-]; > >-use_ok('C4::Letters'); >+fixtures_ok [ >+ Letter => [ >+ [ 'module', 'code', 'branchcode', 'name', 'is_html', 'title', 'content' ], >+ [ 'blah', 'ISBN', 'NBSI', 'book', 1, 'green', 'blahblah' ], >+ [ 'bleh', 'ISSN', 'NSSI', 'page', 0, 'blue', 'blehbleh' ] >+ ], >+], 'add fixtures'; > >-my $dbh = C4::Context->dbh(); >+my $db = Test::MockModule->new('Koha::Database'); >+$db->mock( _new_schema => sub { return Schema(); } ); > >-$dbh->{mock_add_resultset} = $mock_letters; >+use_ok('C4::Letters'); > > t::lib::Mocks::mock_preference('dateformat', 'metric'); > >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 14778
:
42326
|
42388
|
43247
|
43248
|
43249
|
43250
|
43440
|
43631
|
43632
|
43633
|
43634
|
43635
|
43636
|
43637
|
43638
|
43639
|
43640
|
43641
|
43642
|
43643
|
43644
|
43645
|
43834
|
43835
|
43836
|
43837
|
43838
|
43839
|
43840
|
43841
|
43842
|
43843
|
43844
|
43845
|
43846
|
43847
|
43848
|
43849
|
43850
|
43851
|
43852
|
43853
|
43857
|
43858
|
43859
|
43860
|
43861
|
43862
|
43863
|
43864
|
43865
|
43866
|
43867
|
43868
|
43869
|
43870
|
43871
|
43872
|
43873
|
43874
|
43875
|
43876
|
44003