Bugzilla – Attachment 43866 Details for
Bug 14778
DBIC should create/own the DB handler
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[PASSED QA] Bug 14778: Install fixtures for t/Biblio.t
PASSED-QA-Bug-14778-Install-fixtures-for-tBibliot.patch (text/plain), 1.56 KB, created by
Kyle M Hall (khall)
on 2015-10-23 14:56:39 UTC
(
hide
)
Description:
[PASSED QA] Bug 14778: Install fixtures for t/Biblio.t
Filename:
MIME Type:
Creator:
Kyle M Hall (khall)
Created:
2015-10-23 14:56:39 UTC
Size:
1.56 KB
patch
obsolete
>From ba33471bb2f50f8f4123337244d7bc1e9fa2b4f2 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Thu, 15 Oct 2015 16:05:14 +0100 >Subject: [PATCH] [PASSED QA] Bug 14778: Install fixtures for t/Biblio.t > >Note that it already passed before > >Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> > >Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> >--- > t/Biblio.t | 29 +++++++++++++++++++---------- > 1 files changed, 19 insertions(+), 10 deletions(-) > >diff --git a/t/Biblio.t b/t/Biblio.t >index 3217e77..8cf9c9d 100755 >--- a/t/Biblio.t >+++ b/t/Biblio.t >@@ -20,21 +20,30 @@ use Modern::Perl; > use Test::More tests => 46; > use Test::MockModule; > use Test::Warn; >-use DBD::Mock; > > BEGIN { > use_ok('C4::Biblio'); > } > >-my $context = new Test::MockModule('C4::Context'); >-$context->mock( >- '_new_dbh', >- sub { >- my $dbh = DBI->connect( 'DBI:Mock:', '', '' ) >- || die "Cannot create handle: $DBI::errstr\n"; >- return $dbh; >- } >-); >+use Test::DBIx::Class { >+ schema_class => 'Koha::Schema', >+ connect_info => ['dbi:SQLite:dbname=:memory:','',''], >+ connect_opts => { name_sep => '.', quote_char => '`', }, >+ fixture_class => '::Populate', >+}, 'Biblio' ; >+ >+sub fixtures { >+ my ( $data ) = @_; >+ fixtures_ok [ >+ Biblio => [ >+ [ qw/ biblionumber datecreated timestamp / ], >+ @$data, >+ ], >+ ], 'add fixtures'; >+} >+ >+my $db = Test::MockModule->new('Koha::Database'); >+$db->mock( _new_schema => sub { return Schema(); } ); > > my @arr; > my $ret; >-- >1.7.2.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 14778
:
42326
|
42388
|
43247
|
43248
|
43249
|
43250
|
43440
|
43631
|
43632
|
43633
|
43634
|
43635
|
43636
|
43637
|
43638
|
43639
|
43640
|
43641
|
43642
|
43643
|
43644
|
43645
|
43834
|
43835
|
43836
|
43837
|
43838
|
43839
|
43840
|
43841
|
43842
|
43843
|
43844
|
43845
|
43846
|
43847
|
43848
|
43849
|
43850
|
43851
|
43852
|
43853
|
43857
|
43858
|
43859
|
43860
|
43861
|
43862
|
43863
|
43864
|
43865
| 43866 |
43867
|
43868
|
43869
|
43870
|
43871
|
43872
|
43873
|
43874
|
43875
|
43876
|
44003