Attachment 43918 Details for Bug 14248 – Bug 12428: QA Follow-up: Wrap borrower's title in a span to make it possible to hide

[patch] Bug 12428: QA Follow-up: Wrap borrower's title in a span to make it possible to hide

Bug-12428-QA-Follow-up-Wrap-borrowers-title-in-a-s.patch (text/plain), 3.15 KB, created by Katrin Fischer on 2015-10-24 11:34:23 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Katrin Fischer

Created: 2015-10-24 11:34:23 UTC

Size: 3.15 KB

patch

obsolete

>From 06eabd6f398488e09d6a06e865b052ee51630b2d Mon Sep 17 00:00:00 2001
>From: Katrin Fischer <Katrin.Fischer.83@web.de>
>Date: Sat, 24 Oct 2015 13:09:41 +0200
>Subject: [PATCH] Bug 12428: QA Follow-up: Wrap borrower's title in a span to
> make it possible to hide
>
>I think showing the title with the user name is quite unusual for
>Koha. Wrapping the title in a span with a unique class makes it
>possible to hide it.
>
>http://bugs.koha-community.org/show_bug.cgi?id=14248
>---
> koha-tmpl/intranet-tmpl/prog/en/modules/intranet-main.tt | 2 +-
> koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-main.tt    | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/intranet-main.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/intranet-main.tt
>index aba7fc0..d0be0da 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/intranet-main.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/intranet-main.tt
>@@ -175,7 +175,7 @@
>             [% FOREACH koha_new IN koha_news %]
>                 <div class="newsitem" id="news[% koha_new.idnew %]"><h4>[% koha_new.title %]</h4>
>                     <p>[% koha_new.new %]</p>
>-                    <p class="newsfooter"> Posted on [% koha_new.newdate %][% IF( ( newsdisp == 'staff' || newsdisp == 'both' ) && koha_new.borrowernumber ) %] by [% koha_new.author_title %] [% koha_new.author_firstname %] [% koha_new.author_surname %]<br />[% END %]
>+                    <p class="newsfooter"> Posted on [% koha_new.newdate %][% IF( ( newsdisp == 'staff' || newsdisp == 'both' ) && koha_new.borrowernumber ) %] by <span class="newsauthor_title">[% koha_new.author_title %] </span>[% koha_new.author_firstname %] [% koha_new.author_surname %]<br />[% END %]
>                         [% IF ( CAN_user_tools ) %]
>                             <a href="/cgi-bin/koha/tools/koha-news.pl?op=add_form&amp;id=[% koha_new.idnew %]">Edit</a>
>                              | <a href="/cgi-bin/koha/tools/koha-news.pl?op=del&amp;ids=[% koha_new.idnew %]">Delete</a>
>diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-main.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-main.tt
>index 6da2b54..7e51a94 100644
>--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-main.tt
>+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-main.tt
>@@ -45,7 +45,7 @@
>                     <div class="newsitem">
>                         <a name="newsitem[% koha_new.idnew %]"></a><h4 class="newsheader">[% koha_new.title %]</h4>
>                         <div class="newsbody">[% koha_new.new %]</div>
>-                        <div class="newsfooter">(published on [% koha_new.newdate %][% IF ( (newsdisp == 'opac' || newsdisp == 'both') && koha_new.borrowernumber ) %] by [% koha_new.author_title %] [% koha_new.author_firstname %] [% koha_new.author_surname %][% END %])</div>
>+                        <div class="newsfooter">(published on [% koha_new.newdate %][% IF ( (newsdisp == 'opac' || newsdisp == 'both') && koha_new.borrowernumber ) %] by <span class="newsauthor_title">[% koha_new.author_title %] </span>[% koha_new.author_firstname %] [% koha_new.author_surname %][% END %])</div>
>                     </div>
>                 [% END %]
>             </div>
>-- 
>1.9.1

Actions: View | Diff | Splinter Review

Attachments on bug 14248: 39363 | 39415 | 39441 | 43046 | 43421 | 43766 | 43769 | 43916 | 43917 | 43918