Attachment 43935 Details for Bug 14949 – [PASSED QA] Bug 14949 - (followup) Fix regression with hard due date

[patch] [PASSED QA] Bug 14949 - (followup) Fix regression with hard due date

PASSED-QA-Bug-14949---followup-Fix-regression-with.patch (text/plain), 1.71 KB, created by Katrin Fischer on 2015-10-24 20:50:29 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Katrin Fischer

Created: 2015-10-24 20:50:29 UTC

Size: 1.71 KB

patch

obsolete

>From ce168a701dd767282cc5ccf5a3f6e609f6051d07 Mon Sep 17 00:00:00 2001
>From: =?UTF-8?q?Marc=20V=C3=A9ron?= <veron@veron.ch>
>Date: Tue, 6 Oct 2015 15:06:25 +0200
>Subject: [PATCH] [PASSED QA] Bug 14949 - (followup) Fix regression with hard
> due date
>
>This patch fixes the regresseion as described in comment #3
>
>To test:
>
>- Go on smart-rules.pl and edit a line. Do not define a Hard due date, save.
>  The value is "None defined".
>
>- Edit the line, do not change anything and save.
>  The value should be "None defined"
>
>- Edit the line, define a hard due date, save.
>  The date should display as expected.
>
>- Edit the line agein, remove the hard due date, save.
>  The value should be "None defined"
>
>Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com>
>Works as advertised
>
>Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
>---
> admin/smart-rules.pl | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
>diff --git a/admin/smart-rules.pl b/admin/smart-rules.pl
>index 05c81d5..2722f6d 100755
>--- a/admin/smart-rules.pl
>+++ b/admin/smart-rules.pl
>@@ -126,7 +126,8 @@ elsif ($op eq 'add') {
>     $maxonsiteissueqty = undef if $maxonsiteissueqty !~ /^\d+/;
>     my $issuelength  = $input->param('issuelength');
>     my $lengthunit  = $input->param('lengthunit');
>-    my $hardduedate = eval { dt_from_string( $input->param('hardduedate') ) };
>+    my $hardduedate = $input->param('hardduedate');
>+    $hardduedate = eval { dt_from_string( $input->param('hardduedate') ) } if ( $hardduedate );
>     $hardduedate = output_pref( { dt => $hardduedate, dateonly => 1, dateformat => 'iso' } ) if ( $hardduedate );
>     my $hardduedatecompare = $input->param('hardduedatecompare');
>     my $rentaldiscount = $input->param('rentaldiscount');
>-- 
>1.9.1

Actions: View | Diff | Splinter Review

Attachments on bug 14949: 43094 | 43101 | 43169 | 43409 | 43884 | 43885 | 43934 | 43935 | 43936