Bugzilla – Attachment 43967 Details for
Bug 14915
Use Font Awesome instead of Glyphicons for the staff intranet
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 14915: [FA 4.4] QA Follow-up - Replace fa-hold with fa-sticky-note-o
Bug-14915-FA-44-QA-Follow-up---Replace-fa-hold-wit.patch (text/plain), 4.85 KB, created by
Katrin Fischer
on 2015-10-25 22:18:17 UTC
(
hide
)
Description:
Bug 14915: [FA 4.4] QA Follow-up - Replace fa-hold with fa-sticky-note-o
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2015-10-25 22:18:17 UTC
Size:
4.85 KB
patch
obsolete
>From 617909f3054adb26d7a5338eeeec7dc8d83813c6 Mon Sep 17 00:00:00 2001 >From: Katrin Fischer <Katrin.Fischer.83@web.de> >Date: Sun, 25 Oct 2015 23:01:11 +0100 >Subject: [PATCH] Bug 14915: [FA 4.4] QA Follow-up - Replace fa-hold with > fa-sticky-note-o > >Ok, this is a fun one: There is no icon like our current hold icon >in Font Awesome. So I picked fa-sticky-note-o for a replacement. > >But since this is a new one, it doesn't exist in Koha yet. >I found no better match and the patch was already written... >--- > koha-tmpl/intranet-tmpl/prog/en/includes/cat-toolbar.inc | 4 ++-- > koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt | 6 +++--- > koha-tmpl/intranet-tmpl/prog/en/modules/virtualshelves/shelves.tt | 2 +- > 3 files changed, 6 insertions(+), 6 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/cat-toolbar.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/cat-toolbar.inc >index e173091..3e604d2 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/cat-toolbar.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/cat-toolbar.inc >@@ -248,7 +248,7 @@ CAN_user_serials_create_subscription ) %] > [% IF ( holdfor ) %] > <div class="btn-group"> > <button class="btn btn-small dropdown-toggle" data-toggle="dropdown"> >- <i class="fa fa-hold"></i> >+ <i class="fa fa-sticky-note-o"></i> > Place hold > <span class="caret"></span> > </button> >@@ -258,7 +258,7 @@ CAN_user_serials_create_subscription ) %] > </ul> > </div> > [% ELSE %] >- <div class="btn-group"><a id="placehold" class="btn btn-small" href="/cgi-bin/koha/reserve/request.pl?biblionumber=[% biblionumber %]"><i class="fa fa-hold"></i> Place hold</a></div> >+ <div class="btn-group"><a id="placehold" class="btn btn-small" href="/cgi-bin/koha/reserve/request.pl?biblionumber=[% biblionumber %]"><i class="fa fa-sticky-note-o"></i> Place hold</a></div> > [% END %] > [% END %] > [% END %] >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt >index 62e2ec9..1f79253 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt >@@ -206,7 +206,7 @@ function placeHold () { > function forgetPatron(){ > $.removeCookie("holdfor", { path: '/' }); > $(".holdforlink").remove(); >- $("#placeholdc").html("<a class=\"btn btn-mini placehold\" href=\"#\"><i class=\"fa fa-hold\"></i> "+_("Place hold")+"</a>"); >+ $("#placeholdc").html("<a class=\"btn btn-mini placehold\" href=\"#\"><i class=\"fa fa-sticky-note-o"\"></i> "+_("Place hold")+"</a>"); > } > > function addToList () { >@@ -318,7 +318,7 @@ var holdForPatron = function () { > [% IF ( CAN_user_reserveforothers && DisplayMultiPlaceHold ) %] > [% IF ( holdfor ) %] > <div id="placeholdc" class="btn-group"> >- <button class="btn btn-mini placehold"><i class="fa fa-hold"></i> Place hold</button> >+ <button class="btn btn-mini placehold"><i class="fa fa-sticky-note-o"></i> Place hold</button> > <button class="btn btn-mini dropdown-toggle" data-toggle="dropdown"> > <span class="caret"></span> > </button> >@@ -330,7 +330,7 @@ var holdForPatron = function () { > </ul> > </div> > [% ELSE %] >- <div id="placeholdc" class="btn-group"><a class="btn btn-mini placehold" href="#"><i class="fa fa-hold"></i> Place hold</a></div> >+ <div id="placeholdc" class="btn-group"><a class="btn btn-mini placehold" href="#"><i class="fa fa-sticky-note-o""></i> Place hold</a></div> > [% END %] > [% END %] > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/virtualshelves/shelves.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/virtualshelves/shelves.tt >index 169bc28..46cc916 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/virtualshelves/shelves.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/virtualshelves/shelves.tt >@@ -376,7 +376,7 @@ function placeHold () { > <span class="addto">| </span> > > [% IF ( CAN_user_reserveforothers && DisplayMultiPlaceHold ) %] >- <div class="btn-group"><button class="btn btn-mini placehold"><i class="fa fa-hold"></i> Place hold</button></div> >+ <div class="btn-group"><button class="btn btn-mini placehold"><i class="fa fa-sticky-note-o"></i> Place hold</button></div> > [% END %] > [% IF ( allowremovingitems ) %] > <div class="btn-group"><button type="submit" class="btn btn-mini list-remove"><i class="fa fa-times-circle"></i> Remove selected</button></div> >-- >1.9.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 14915
:
42925
|
42929
|
42943
|
43275
|
43277
|
43959
|
43960
|
43961
|
43962
|
43963
|
43964
|
43965
|
43966
| 43967 |
43968
|
44014
|
44841