Attachment 43987 Details for Bug 13799 – Bug 13799: Followup of "Followup: x-mojo-controller deprecation"

[patch] Bug 13799: Followup of "Followup: x-mojo-controller deprecation"

Bug-13799-Followup-of-Followup-x-mojo-controller-d.patch (text/plain), 12.44 KB, created by Julian Maurice on 2015-10-26 12:59:34 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Julian Maurice

Created: 2015-10-26 12:59:34 UTC

Size: 12.44 KB

patch

obsolete

>From 4a9ea578a5268028fccdde7a7bce134f2c20a67e Mon Sep 17 00:00:00 2001
>From: Julian Maurice <julian.maurice@biblibre.com>
>Date: Mon, 26 Oct 2015 11:43:35 +0100
>Subject: [PATCH] Bug 13799: Followup of "Followup: x-mojo-controller
> deprecation"
>
>Rename controller Koha::REST::V1::Patrons to Koha::REST::V1::Patron so
>Swagger2 can find it
>
>Also change most of the  "type" specifications in patron schema object,
>since most of the fields can be null.
>---
> Koha/REST/V1/{Patrons.pm => Patron.pm} |   2 +-
> api/v1/definitions/patron.json         | 122 ++++++++++++++++-----------------
> 2 files changed, 62 insertions(+), 62 deletions(-)
> rename Koha/REST/V1/{Patrons.pm => Patron.pm} (98%)
>
>diff --git a/Koha/REST/V1/Patrons.pm b/Koha/REST/V1/Patron.pm
>similarity index 98%
>rename from Koha/REST/V1/Patrons.pm
>rename to Koha/REST/V1/Patron.pm
>index dfeb1dc..fee6c31 100644
>--- a/Koha/REST/V1/Patrons.pm
>+++ b/Koha/REST/V1/Patron.pm
>@@ -1,4 +1,4 @@
>-package Koha::REST::V1::Patrons;
>+package Koha::REST::V1::Patron;
> 
> # This file is part of Koha.
> #
>diff --git a/api/v1/definitions/patron.json b/api/v1/definitions/patron.json
>index 1b35785..30384e2 100644
>--- a/api/v1/definitions/patron.json
>+++ b/api/v1/definitions/patron.json
>@@ -2,11 +2,11 @@
>       "type": "object",
>       "properties": {
>         "borrowernumber": {
>-          "type": "integer",
>+          "type": "string",
>           "description": "internally assigned user identifier"
>         },
>         "cardnumber": {
>-          "type": "string",
>+          "type": ["string", "null"],
>           "description": "library assigned user identifier"
>         },
>         "surname": {
>@@ -14,27 +14,27 @@
>           "description": "patron's last name"
>         },
>         "firstname": {
>-          "type": "string",
>+          "type": ["string", "null"],
>           "description": "patron's first name"
>         },
>         "title": {
>-          "type": "string",
>+          "type": ["string", "null"],
>           "description": "patron's title"
>         },
>         "othernames": {
>-          "type": "string",
>+          "type": ["string", "null"],
>           "description": "any other names associated with the patron"
>         },
>         "initials": {
>-          "type": "string",
>+          "type": ["string", "null"],
>           "description": "initials of the patron"
>         },
>         "streetnumber": {
>-          "type": "string",
>+          "type": ["string", "null"],
>           "description": "street number of patron's primary address"
>         },
>         "streettype": {
>-          "type": "string",
>+          "type": ["string", "null"],
>           "description": "street type of patron's primary address"
>         },
>         "address": {
>@@ -42,7 +42,7 @@
>           "description": "first address line of patron's primary address"
>         },
>         "address2": {
>-          "type": "string",
>+          "type": ["string", "null"],
>           "description": "second address line of patron's primary address"
>         },
>         "city": {
>@@ -50,83 +50,83 @@
>           "description": "city or town of patron's primary address"
>         },
>         "state": {
>-          "type": "string",
>+          "type": ["string", "null"],
>           "description": "state or province of patron's primary address"
>         },
>         "zipcode": {
>-          "type": "string",
>+          "type": ["string", "null"],
>           "description": "zip or postal code of patron's primary address"
>         },
>         "country": {
>-          "type": "string",
>+          "type": ["string", "null"],
>           "description": "country of patron's primary address"
>         },
>         "email": {
>-          "type": "string",
>+          "type": ["string", "null"],
>           "description": "primary email address for patron's primary address"
>         },
>         "phone": {
>-          "type": "string",
>+          "type": ["string", "null"],
>           "description": "primary phone number for patron's primary address"
>         },
>         "mobile": {
>-          "type": "string",
>+          "type": ["string", "null"],
>           "description": "the other phone number for patron's primary address"
>         },
>         "fax": {
>-          "type": "string",
>+          "type": ["string", "null"],
>           "description": "fax number for patron's primary address"
>         },
>         "emailpro": {
>-          "type": "string",
>+          "type": ["string", "null"],
>           "description": "secondary email address for patron's primary address"
>         },
>         "phonepro": {
>-          "type": "string",
>+          "type": ["string", "null"],
>           "description": "secondary phone number for patron's primary address"
>         },
>         "B_streetnumber": {
>-          "type": "string",
>+          "type": ["string", "null"],
>           "description": "street number of patron's alternate address"
>         },
>         "B_streettype": {
>-          "type": "string",
>+          "type": ["string", "null"],
>           "description": "street type of patron's alternate address"
>         },
>         "B_address": {
>-          "type": "string",
>+          "type": ["string", "null"],
>           "description": "first address line of patron's alternate address"
>         },
>         "B_address2": {
>-          "type": "string",
>+          "type": ["string", "null"],
>           "description": "second address line of patron's alternate address"
>         },
>         "B_city": {
>-          "type": "string",
>+          "type": ["string", "null"],
>           "description": "city or town of patron's alternate address"
>         },
>         "B_state": {
>-          "type": "string",
>+          "type": ["string", "null"],
>           "description": "state or province of patron's alternate address"
>         },
>         "B_zipcode": {
>-          "type": "string",
>+          "type": ["string", "null"],
>           "description": "zip or postal code of patron's alternate address"
>         },
>         "B_country": {
>-          "type": "string",
>+          "type": ["string", "null"],
>           "description": "country of patron's alternate address"
>         },
>         "B_email": {
>-          "type": "string",
>+          "type": ["string", "null"],
>           "description": "email address for patron's alternate address"
>         },
>         "B_phone": {
>-          "type": "string",
>+          "type": ["string", "null"],
>           "description": "phone number for patron's alternate address"
>         },
>         "dateofbirth": {
>-          "type": "string",
>+          "type": ["string", "null"],
>           "description": "patron's date of birth"
>         },
>         "branchcode": {
>@@ -138,131 +138,131 @@
>           "description": "code of patron's category"
>         },
>         "dateenrolled": {
>-          "type": "string",
>+          "type": ["string", "null"],
>           "description": "date the patron was added to Koha"
>         },
>         "dateexpiry": {
>-          "type": "string",
>+          "type": ["string", "null"],
>           "description": "date the patron's card is set to expire"
>         },
>         "gonenoaddress": {
>-          "type": "string",
>+          "type": ["string", "null"],
>           "description": "set to 1 if library marked this patron as having an unconfirmed address"
>         },
>         "lost": {
>-          "type": "string",
>+          "type": ["string", "null"],
>           "description": "set to 1 if library marked this patron as having lost his card"
>         },
>         "debarred": {
>-          "type": "string",
>+          "type": ["string", "null"],
>           "description": "until this date the patron can only check-in"
>         },
>         "debarredcomment": {
>-          "type": "string",
>+          "type": ["string", "null"],
>           "description": "comment on the stop of the patron"
>         },
>         "contactname": {
>-          "type": "string",
>+          "type": ["string", "null"],
>           "description": "used for children and professionals to include surname or last name of guarantor or organization name"
>         },
>         "contactfirstname": {
>-          "type": "string",
>+          "type": ["string", "null"],
>           "description": "used for children to include first name of guarantor"
>         },
>         "contacttitle": {
>-          "type": "string",
>+          "type": ["string", "null"],
>           "description": "used for children to include title of guarantor"
>         },
>         "guarantorid": {
>-          "type": "integer",
>+          "type": ["string", "null"],
>           "description": "borrowernumber used for children or professionals to link them to guarantor or organizations"
>         },
>         "borrowernotes": {
>-          "type": "string",
>+          "type": ["string", "null"],
>           "description": "a note on the patron's account"
>         },
>         "relationship": {
>-          "type": "string",
>+          "type": ["string", "null"],
>           "description": "used for children to include the relationship to their guarantor"
>         },
>         "ethnicity": {
>-          "type": "string",
>+          "type": ["string", "null"],
>           "description": "unused"
>         },
>         "ethnotes": {
>-          "type": "string",
>+          "type": ["string", "null"],
>           "description": "unused"
>         },
>         "sex": {
>-          "type": "string",
>+          "type": ["string", "null"],
>           "description": "patron's gender"
>         },
>         "password": {
>-          "type": "string",
>+          "type": ["string", "null"],
>           "description": "patron's encrypted password"
>         },
>         "flags": {
>-          "type": "string",
>+          "type": ["string", "null"],
>           "description": "a number associated with the patron's permissions"
>         },
>         "userid": {
>-          "type": "string",
>+          "type": ["string", "null"],
>           "description": "patron's login"
>         },
>         "opacnote": {
>-          "type": "string",
>+          "type": ["string", "null"],
>           "description": "a note on the patron's account visible in OPAC and staff client"
>         },
>         "contactnote": {
>-          "type": "string",
>+          "type": ["string", "null"],
>           "description": "a note related to patron's alternate address"
>         },
>         "sort1": {
>-          "type": "string",
>+          "type": ["string", "null"],
>           "description": "a field that can be used for any information unique to the library"
>         },
>         "sort2": {
>-          "type": "string",
>+          "type": ["string", "null"],
>           "description": "a field that can be used for any information unique to the library"
>         },
>         "altcontactfirstname": {
>-          "type": "string",
>+          "type": ["string", "null"],
>           "description": "first name of alternate contact for the patron"
>         },
>         "altcontactsurname": {
>-          "type": "string",
>+          "type": ["string", "null"],
>           "description": "surname or last name of the alternate contact for the patron"
>         },
>         "altcontactaddress1": {
>-          "type": "string",
>+          "type": ["string", "null"],
>           "description": "the first address line for the alternate contact for the patron"
>         },
>         "altcontactaddress2": {
>-          "type": "string",
>+          "type": ["string", "null"],
>           "description": "the second address line for the alternate contact for the patron"
>         },
>         "altcontactaddress3": {
>-          "type": "string",
>+          "type": ["string", "null"],
>           "description": "the city for the alternate contact for the patron"
>         },
>         "altcontactstate": {
>-          "type": "string",
>+          "type": ["string", "null"],
>           "description": "the state for the alternate contact for the patron"
>         },
>         "altcontactzipcode": {
>-          "type": "string",
>+          "type": ["string", "null"],
>           "description": "the zipcode for the alternate contact for the patron"
>         },
>         "altcontactcountry": {
>-          "type": "string",
>+          "type": ["string", "null"],
>           "description": "the country for the alternate contact for the patron"
>         },
>         "altcontactphone": {
>-          "type": "string",
>+          "type": ["string", "null"],
>           "description": "the phone number for the alternate contact for the patron"
>         },
>         "smsalertnumber": {
>-          "type": "string",
>+          "type": ["string", "null"],
>           "description": "the mobile phone number where the patron would like to receive notices (if SMS turned on)"
>         },
>         "privacy": {
>-- 
>1.9.1

Actions: View | Diff | Splinter Review

Attachments on bug 13799: 36700 | 36705 | 36938 | 36941 | 37119 | 37132 | 37172 | 38246 | 39156 | 39158 | 39159 | 39160 | 39161 | 39162 | 39163 | 39164 | 40088 | 40092 | 40093 | 40094 | 40098 | 40099 | 40101 | 40140 | 40141 | 40142 | 40463 | 40464 | 40465 | 40466 | 40467 | 40468 | 40469 | 40470 | 40471 | 40551 | 40552 | 40553 | 40554 | 40560 | 40561 | 40584 | 40585 | 40586 | 40587 | 40616 | 40617 | 40618 | 40619 | 41160 | 41161 | 41162 | 41268 | 41269 | 41270 | 41271 | 41272 | 41273 | 41274 | 41320 | 41321 | 41326 | 41327 | 41328 | 41329 | 41330 | 41331 | 41538 | 41539 | 41540 | 41541 | 41542 | 41543 | 41547 | 41554 | 42044 | 42085 | 42086 | 42123 | 42518 | 42766 | 42768 | 42801 | 42874 | 42875 | 42876 | 42877 | 42878 | 43186 | 43187 | 43189 | 43190 | 43191 | 43192 | 43204 | 43205 | 43206 | 43207 | 43208 | 43209 | 43210 | 43211 | 43212 | 43213 | 43214 | 43980 | 43981 | 43987 | 43989 | 43990 | 43991 | 43992 | 43993 | 43994 | 43995 | 43996 | 43997 | 43998 | 43999 | 44000 | 44001 | 44185 | 44285 | 44313 | 44375 | 44376 | 44377 | 44378 | 44379 | 44380 | 44381 | 44382 | 44383 | 44384 | 44385