Bugzilla – Attachment 44247 Details for
Bug 14821
Don't show item in checked in list, when it wasn't checked in
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[PASSED QA] Bug 14821: Do not list not returned items
PASSED-QA-Bug-14821-Do-not-list-not-returned-items.patch (text/plain), 1.57 KB, created by
Kyle M Hall (khall)
on 2015-10-30 18:22:00 UTC
(
hide
)
Description:
[PASSED QA] Bug 14821: Do not list not returned items
Filename:
MIME Type:
Creator:
Kyle M Hall (khall)
Created:
2015-10-30 18:22:00 UTC
Size:
1.57 KB
patch
obsolete
>From d7c2986d8a099099db97dacea3f9b179365fdf1a Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Tue, 15 Sep 2015 08:24:07 +0100 >Subject: [PATCH] [PASSED QA] Bug 14821: Do not list not returned items > >On the checkin page, the table is always filled with info of the scanned >barcode, even if the checkin has failed. >When the checkin fails, there is already an error displayed, so there is >no need to keep a row for fails. > >Test plan: >Confirm that the failed checkins don't appear anymore in the checkin >table. >- checkin an item which is not issued; >- BlockReturnOfWithdrawnItems is set and item is withdrawn; >- Not returned at the right place; >- privacy=2 and AnonymousPatron not correctly set; > >Before this patch this behavior existed only for bad barcode. > >Signed-off-by: Frederic Demians <f.demians@tamil.fr> > I confirm that the checkin table hasn't to be populated with info on items > which haven't been checked in. > >Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> >--- > circ/returns.pl | 6 ------ > 1 files changed, 0 insertions(+), 6 deletions(-) > >diff --git a/circ/returns.pl b/circ/returns.pl >index 637f4b2..3948a6e 100755 >--- a/circ/returns.pl >+++ b/circ/returns.pl >@@ -345,12 +345,6 @@ if ($barcode) { > } > } > } >- elsif ( !$messages->{'BadBarcode'} ) { >- $input{duedate} = 0; >- $returneditems{0} = $barcode; >- $riduedate{0} = 0; >- push( @inputloop, \%input ); >- } > $template->param( privacy => $borrower->{privacy} ); > } > $template->param( inputloop => \@inputloop ); >-- >1.7.2.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 14821
:
42548
|
44054
| 44247