Attachment 44262 Details for Bug 15009 – [SIGNED-OFF] Bug 15009 - Planning dropdown button in aqbudget can have empty line

[patch] [SIGNED-OFF] Bug 15009 - Planning dropdown button in aqbudget can have empty line

SIGNED-OFF-Bug-15009---Planning-dropdown-button-in.patch (text/plain), 1.53 KB, created by Bernardo Gonzalez Kriegel on 2015-10-30 23:56:59 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Bernardo Gonzalez Kriegel

Created: 2015-10-30 23:56:59 UTC

Size: 1.53 KB

patch

obsolete

>From c49677ba6cc6117d52b79f83ed9d163ee3a5b754 Mon Sep 17 00:00:00 2001
>From: Blou <philippe.blouin@inlibro.com>
>Date: Tue, 13 Oct 2015 16:12:49 -0400
>Subject: [PATCH] [SIGNED-OFF] Bug 15009 - Planning dropdown button in aqbudget
> can have empty line
>
>When displaying a budget, the Planning button in the admin toolbar displays
>
>Plan by months
>Plan by libraries
>Plan by item types
>Plan by
>
>The last one is empty, due to C4::Budgets::GetBudgetAuthCats returning an empty field if the budget has no sort defined.
>This prevents returning an array with empty element(s)
>
>TEST:
>1) Admin -> Budgets
>2) Select a budget
>   a) you must have '' (empty) in your aqbudgets.sort1_authcat field.
>   b) edit the budget (direct DB or interface) to get that.
>3) Click on Planning dropdown, see the "Plan by <nothing> " entry.
>4) apply the patch, revalidate.
>
>Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
>
>No more empty option
>No errors
>---
> C4/Budgets.pm | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/C4/Budgets.pm b/C4/Budgets.pm
>index f2f376a..d0099da 100644
>--- a/C4/Budgets.pm
>+++ b/C4/Budgets.pm
>@@ -412,8 +412,8 @@ sub GetBudgetAuthCats  {
>     $sth->execute($budget_period_id);
>     my %authcats;
>     while (my ($sort1_authcat,$sort2_authcat) = $sth->fetchrow) {
>-        $authcats{$sort1_authcat}=1;
>-        $authcats{$sort2_authcat}=1;
>+        $authcats{$sort1_authcat}=1 if $sort1_authcat;
>+        $authcats{$sort2_authcat}=1 if $sort2_authcat;
>     }
>     my @auth_cats_loop;
>     foreach (sort keys %authcats) {
>-- 
>1.9.1

Actions: View | Diff | Splinter Review

Attachments on bug 15009: 43391 | 43392 | 44262 | 49601 | 50293 | 50314 | 50315 | 50316 | 50317