Bugzilla – Attachment 44348 Details for
Bug 15061
Can't add item to rotating collection
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[PASSED QA] Bug 15061: Can't add item to rotating collection
PASSED-QA-Bug-15061-Cant-add-item-to-rotating-coll.patch (text/plain), 2.31 KB, created by
Katrin Fischer
on 2015-11-03 23:46:57 UTC
(
hide
)
Description:
[PASSED QA] Bug 15061: Can't add item to rotating collection
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2015-11-03 23:46:57 UTC
Size:
2.31 KB
patch
obsolete
>From 69b296a80aa8d0d07bfb59c77eac58ae3825ab22 Mon Sep 17 00:00:00 2001 >From: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> >Date: Tue, 3 Nov 2015 12:16:08 -0300 >Subject: [PATCH] [PASSED QA] Bug 15061: Can't add item to rotating collection >MIME-Version: 1.0 >Content-Type: text/plain; charset=UTF-8 >Content-Transfer-Encoding: 8bit > >This patch prevents adding items to invalid (empty) >rotating collection id > >To test: >1) Go to /cgi-bin/koha/rotating_collections/addItems.pl >2) Try to add an item, you get error show in attached pictures >3) Apply the patch >4) Go again to /cgi-bin/koha/rotating_collections/addItems.pl >5) Can't add any items > >I don't know if this is a real problem > >Followed test plan, works as expected. >Signed-off-by: Marc Véron <veron@veron.ch> > >Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> >--- > .../prog/en/modules/rotating_collections/addItems.tt | 11 ++++++++--- > 1 file changed, 8 insertions(+), 3 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/rotating_collections/addItems.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/rotating_collections/addItems.tt >index 25ec9c3..43d4a8b 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/rotating_collections/addItems.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/rotating_collections/addItems.tt >@@ -20,8 +20,13 @@ > <div id="yui-main"> > <div class="yui-b"> > >+ [% IF ( ! colId ) %] >+ <div class="dialog message"> >+ <p>Invalid collection id</p> >+ <p><a href="/cgi-bin/koha/rotating_collections/rotatingCollections.pl">Return to rotating collections home</a></p> >+ </div> >+ [% ELSE %] > [% INCLUDE 'rotating-collections-toolbar.inc' %] >- > <h1>Collection <i>[% colTitle %]</i></h1> > > [% IF ( previousActionAdd ) %] >@@ -112,11 +117,11 @@ > <div class="dialog message">There are no items in this collection.</div> > [% END %] > </div> >- >+ [% END %] > </div> <!-- /.yui-b --> > </div> <!-- /#yui-main --> > <div class="yui-b"> > [% INCLUDE 'tools-menu.inc' %] > </div> > </div> <!-- /#bd --> >-[% INCLUDE 'intranet-bottom.inc' %] >\ No newline at end of file >+[% INCLUDE 'intranet-bottom.inc' %] >-- >1.9.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 15061
:
44044
|
44287
|
44336
|
44337
| 44348