Bugzilla – Attachment 44362 Details for
Bug 8352
Add automatic printing of 'hold to pull' notices
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[SIGNED-OFF] Bug 8352 [QA Followup]
SIGNED-OFF-Bug-8352-QA-Followup.patch (text/plain), 2.31 KB, created by
Kyle M Hall (khall)
on 2015-11-04 12:35:52 UTC
(
hide
)
Description:
[SIGNED-OFF] Bug 8352 [QA Followup]
Filename:
MIME Type:
Creator:
Kyle M Hall (khall)
Created:
2015-11-04 12:35:52 UTC
Size:
2.31 KB
patch
obsolete
>From 20f2444f72a5733fbd182513ea6549bd37e8d132 Mon Sep 17 00:00:00 2001 >From: Kyle M Hall <kyle@bywatersolutions.com> >Date: Tue, 18 Aug 2015 08:07:33 -0400 >Subject: [PATCH] [SIGNED-OFF] Bug 8352 [QA Followup] > >* Add --confirm option to print_holds.pl >* Modify old_reserves to match reserves > >Signed-off-by: Jenice Tate <jtate@mdah.state.ms.us> >--- > installer/data/mysql/atomicupdate/bug_8352.sql | 1 + > misc/cronjobs/holds/print_holds.pl | 12 ++++++++++++ > 2 files changed, 13 insertions(+), 0 deletions(-) > >diff --git a/installer/data/mysql/atomicupdate/bug_8352.sql b/installer/data/mysql/atomicupdate/bug_8352.sql >index 4577e1e..3b7308d 100644 >--- a/installer/data/mysql/atomicupdate/bug_8352.sql >+++ b/installer/data/mysql/atomicupdate/bug_8352.sql >@@ -1,4 +1,5 @@ > ALTER TABLE reserves ADD printed DATETIME NULL AFTER suspend_until; >+ALTER TABLE old_reserves ADD printed DATETIME NULL AFTER suspend_until; > > INSERT INTO letter ( module, code, branchcode, name, is_html, title, content ) VALUES ( > 'reserves', 'HOLD_PLACED_PRINT', '', 'Hold Placed ( Auto-Print )', '0', 'Hold Placed ( Auto-Print )', 'Hold to pull at <<branches.branchname>> >diff --git a/misc/cronjobs/holds/print_holds.pl b/misc/cronjobs/holds/print_holds.pl >index 32e2e15..095b068 100755 >--- a/misc/cronjobs/holds/print_holds.pl >+++ b/misc/cronjobs/holds/print_holds.pl >@@ -39,15 +39,19 @@ use Koha::Database; > my $help = 0; > my $test = 0; > my $verbose = 0; >+my $confirm = 0; > my @printers; > GetOptions( > "help|?" => \$help, > "verbose|v" => \$verbose, > "test|t" => \$test, >+ "confirm|c" => \$confirm, > "printer|p=s" => \@printers, > ); > pod2usage(1) if $help; > pod2usage(1) unless @printers; >+pod2usage(1) unless ( $test || $confirm ); >+pod2usage(1) if ( $test && $confirm ); > > my $schema = Koha::Database->new()->schema(); > >@@ -151,6 +155,14 @@ e.g. print_holds.pl --printer MPL:1 --printer CPL:2 > would add printers for branchcodes MPL and CPL. If a printer is not defined for a given branch, notices for > that branch will not be printed. > >+=item B<--test> >+ >+Run in test mode. Holds will not actually be printed. >+ >+=item B<--confirm> >+ >+Run in production mode. Holds will be printed to printers. >+ > =head1 DESCRIPTION > > B<This program> will print on-demand notices for items in the holds queue as they appear. >-- >1.7.2.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 8352
:
10627
|
10766
|
12523
|
13465
|
14394
|
16338
|
16543
|
27127
|
28333
|
28334
|
28335
|
28651
|
28652
|
28653
|
28654
|
36833
|
36834
|
40749
|
40750
|
40751
|
41579
|
41580
|
41581
|
41582
|
41583
|
44359
|
44360
|
44361
|
44362
|
44363
|
45275
|
45276
|
45277
|
45278
|
45279
|
45362
|
45365
|
45651
|
45652
|
45653
|
45654
|
45655
|
45656
|
45657
|
45658
|
45659
|
46878
|
46879
|
46880
|
46881
|
46882
|
46883
|
46884
|
48127
|
48128
|
48129
|
48130
|
48131
|
48132
|
48133
|
48134
|
48135