Attachment 44457 Details for Bug 14157 – [PASSED QA] Bug 14157 : Notices tab in the patron record should not depend on EnhancedMessagingPreferences to display

[patch] [PASSED QA] Bug 14157 : Notices tab in the patron record should not depend on EnhancedMessagingPreferences to display

PASSED-QA-Bug-14157--Notices-tab-in-the-patron-rec.patch (text/plain), 3.52 KB, created by Katrin Fischer on 2015-11-05 07:06:59 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Katrin Fischer

Created: 2015-11-05 07:06:59 UTC

Size: 3.52 KB

patch

obsolete

>From 693982c5e7fdc92923279fc5e68310ab4b0b1156 Mon Sep 17 00:00:00 2001
>From: Sophie Meynieux <sophie.meynieux@biblibre.com>
>Date: Wed, 4 Nov 2015 19:04:26 +0100
>Subject: [PATCH] [PASSED QA] Bug 14157 : Notices tab in the patron record
> should not depend on EnhancedMessagingPreferences to display
>MIME-Version: 1.0
>Content-Type: text/plain; charset=UTF-8
>Content-Transfer-Encoding: 8bit
>
>Overdue and Hold notices can be sent even if EnhancedMessagingPreference is set to "Don't Allow", so Notices tab have to be visible in all cases.
>
>Test plan :
>  - without patch :
>    - set EnhancedMessagingPreference to "Don't Allow" and go to patron record : there is no Notices tab
>    - set EnhancedMessagingPreference to "Allow" and og to patron record : there is a Notices tab
>
>  - apply this patch :
>    - go to patron record, you cas see a Notices tab
>    - change the value of EnhanceMessagingPreferences, Notices tab is always visible.
>
>Followed test plan, works as expected
>Signed-off-by: Marc VÃ©ron <veron@veron.ch>
>
>Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
>---
> koha-tmpl/intranet-tmpl/prog/en/includes/circ-menu.inc    | 2 --
> koha-tmpl/intranet-tmpl/prog/en/includes/members-menu.inc | 2 --
> 2 files changed, 4 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/circ-menu.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/circ-menu.inc
>index 9137efb..6393a04 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/includes/circ-menu.inc
>+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/circ-menu.inc
>@@ -82,9 +82,7 @@
>     [% IF ( CAN_user_parameters ) %]
>         [% IF ( logview ) %]<li class="active">[% ELSE %]<li>[% END %]<a href="/cgi-bin/koha/tools/viewlog.pl?do_it=1&amp;modules=MEMBERS&amp;modules=circulation&amp;object=[% borrowernumber %]&amp;src=circ">Modification log</a></li>
>     [% END %]
>-    [% IF ( EnhancedMessagingPreferences ) %]
> 	[% IF ( sentnotices ) %]<li class="active">[% ELSE %]<li>[% END %]<a href="/cgi-bin/koha/members/notices.pl?borrowernumber=[% borrowernumber %]">Notices</a></li>
>-    [% END %]
>     
>     [% IF ( CAN_user_borrowers ) %]
>         [% IF (  statisticsview ) %]<li class="active">[% ELSE %]<li>[% END %]<a href="/cgi-bin/koha/members/statistics.pl?borrowernumber=[% borrowernumber %]">Statistics</a></li>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/members-menu.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/members-menu.inc
>index e7e8772..486c3ee 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/includes/members-menu.inc
>+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/members-menu.inc
>@@ -12,9 +12,7 @@
>     [% IF ( CAN_user_parameters ) %]
>         [% IF ( logview ) %]<li class="active">[% ELSE %]<li>[% END %]<a href="/cgi-bin/koha/tools/viewlog.pl?do_it=1&amp;modules=MEMBERS&amp;action=MODIFY&amp;object=[% borrowernumber %]">Modification log</a></li>
>     [% END %]
>-    [% IF ( EnhancedMessagingPreferences ) %]
> 	[% IF ( sentnotices ) %]<li class="active">[% ELSE %]<li>[% END %]<a href="/cgi-bin/koha/members/notices.pl?borrowernumber=[% borrowernumber %]">Notices</a></li>
>-    [% END %]
>     [% IF (  statisticsview ) %]<li class="active">[% ELSE %]<li>[% END %]<a href="/cgi-bin/koha/members/statistics.pl?borrowernumber=[% borrowernumber %]">Statistics</a></li>
>     [% IF EnableBorrowerFiles %]
>         [% IF ( borrower_files ) %]<li class="active">[% ELSE %]<li>[% END %]<a href="/cgi-bin/koha/members/files.pl?borrowernumber=[% borrowernumber %]">Files</a></li>
>-- 
>1.9.1

Actions: View | Diff | Splinter Review

Attachments on bug 14157: 44437 | 44450 | 44457