Bugzilla – Attachment 44474 Details for
Bug 14544
Move the list related code to Koha::Virtualshelves
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 14544: Move HandleDelBorrower to C4::Members
Bug-14544-Move-HandleDelBorrower-to-C4Members.patch (text/plain), 3.67 KB, created by
Jonathan Druart
on 2015-11-05 11:08:00 UTC
(
hide
)
Description:
Bug 14544: Move HandleDelBorrower to C4::Members
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2015-11-05 11:08:00 UTC
Size:
3.67 KB
patch
obsolete
>From c938105ed7891f1a1548e472d513998d7b36a3cc Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Tue, 18 Aug 2015 10:50:06 +0100 >Subject: [PATCH] Bug 14544: Move HandleDelBorrower to C4::Members > >Signed-off-by: Alex Arnaud <alex.arnaud@biblibre.com> > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >--- > C4/Members.pm | 34 ++++++++++++++++++++++++++++++++++ > C4/VirtualShelves.pm | 34 ---------------------------------- > 2 files changed, 34 insertions(+), 34 deletions(-) > >diff --git a/C4/Members.pm b/C4/Members.pm >index 9507b9f..171f3c0 100644 >--- a/C4/Members.pm >+++ b/C4/Members.pm >@@ -1816,6 +1816,40 @@ sub DelMember { > return $sth->rows; > } > >+=head2 HandleDelBorrower >+ >+ HandleDelBorrower($borrower); >+ >+When a member is deleted (DelMember in Members.pm), you should call me first. >+This routine deletes/moves lists and entries for the deleted member/borrower. >+Lists owned by the borrower are deleted, but entries from the borrower to >+other lists are kept. >+ >+=cut >+ >+sub HandleDelBorrower { >+ my ($borrower)= @_; >+ my $query; >+ my $dbh = C4::Context->dbh; >+ >+ #Delete all lists and all shares of this borrower >+ #Consistent with the approach Koha uses on deleting individual lists >+ #Note that entries in virtualshelfcontents added by this borrower to >+ #lists of others will be handled by a table constraint: the borrower >+ #is set to NULL in those entries. >+ $query="DELETE FROM virtualshelves WHERE owner=?"; >+ $dbh->do($query,undef,($borrower)); >+ >+ #NOTE: >+ #We could handle the above deletes via a constraint too. >+ #But a new BZ report 11889 has been opened to discuss another approach. >+ #Instead of deleting we could also disown lists (based on a pref). >+ #In that way we could save shared and public lists. >+ #The current table constraints support that idea now. >+ #This pref should then govern the results of other routines/methods such as >+ #Koha::Virtualshelf->new->delete too. >+} >+ > =head2 ExtendMemberSubscriptionTo (OUEST-PROVENCE) > > $date = ExtendMemberSubscriptionTo($borrowerid, $date); >diff --git a/C4/VirtualShelves.pm b/C4/VirtualShelves.pm >index 29126cc..6c74155 100644 >--- a/C4/VirtualShelves.pm >+++ b/C4/VirtualShelves.pm >@@ -83,40 +83,6 @@ sub ShelvesMax { > return SHELVES_MASTHEAD_MAX; > } > >-=head2 HandleDelBorrower >- >- HandleDelBorrower($borrower); >- >-When a member is deleted (DelMember in Members.pm), you should call me first. >-This routine deletes/moves lists and entries for the deleted member/borrower. >-Lists owned by the borrower are deleted, but entries from the borrower to >-other lists are kept. >- >-=cut >- >-sub HandleDelBorrower { >- my ($borrower)= @_; >- my $query; >- my $dbh = C4::Context->dbh; >- >- #Delete all lists and all shares of this borrower >- #Consistent with the approach Koha uses on deleting individual lists >- #Note that entries in virtualshelfcontents added by this borrower to >- #lists of others will be handled by a table constraint: the borrower >- #is set to NULL in those entries. >- $query="DELETE FROM virtualshelves WHERE owner=?"; >- $dbh->do($query,undef,($borrower)); >- >- #NOTE: >- #We could handle the above deletes via a constraint too. >- #But a new BZ report 11889 has been opened to discuss another approach. >- #Instead of deleting we could also disown lists (based on a pref). >- #In that way we could save shared and public lists. >- #The current table constraints support that idea now. >- #This pref should then govern the results of other routines/methods such as >- #Koha::Virtualshelf->new->delete too. >-} >- > sub GetShelfCount { > my ($owner, $category) = @_; > my @params; >-- >2.1.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 14544
:
41034
|
41035
|
41036
|
41037
|
41038
|
41039
|
41040
|
41041
|
41042
|
41403
|
41404
|
41405
|
41406
|
41407
|
41408
|
41409
|
41410
|
41411
|
41412
|
41584
|
41585
|
41586
|
41587
|
41588
|
41589
|
41590
|
41591
|
41592
|
41593
|
41594
|
41595
|
41596
|
41597
|
41598
|
41599
|
41600
|
41601
|
41716
|
41717
|
41718
|
41719
|
41720
|
41721
|
41722
|
41723
|
41724
|
41725
|
41726
|
41727
|
41728
|
41729
|
41730
|
41731
|
41732
|
41733
|
41766
|
41909
|
41910
|
41913
|
41914
|
41915
|
41917
|
41918
|
41919
|
41924
|
41927
|
41931
|
41932
|
41953
|
41954
|
41955
|
41956
|
41957
|
41958
|
41959
|
41960
|
41961
|
41962
|
41963
|
41964
|
41965
|
41966
|
41967
|
41968
|
41969
|
41970
|
41973
|
41974
|
41975
|
41976
|
41977
|
41978
|
41979
|
41980
|
41981
|
41982
|
41983
|
41986
|
41988
|
42192
|
42199
|
42200
|
42201
|
42202
|
42203
|
42204
|
42205
|
42206
|
42207
|
42208
|
42209
|
42210
|
42211
|
42212
|
42213
|
42214
|
42215
|
42216
|
42217
|
42218
|
42219
|
42638
|
43223
|
43224
|
43225
|
43226
|
43227
|
43228
|
43229
|
43230
|
43231
|
43232
|
43233
|
43234
|
43235
|
43236
|
43237
|
43238
|
43239
|
43240
|
43241
|
43242
|
43243
|
43296
|
43334
|
43335
|
43403
|
43456
|
43457
|
43458
|
43459
|
43460
|
43461
|
43462
|
43463
|
43464
|
43465
|
43466
|
43467
|
43469
|
43470
|
43471
|
43472
|
43473
|
43474
|
43475
|
43476
|
43477
|
43478
|
43479
|
43480
|
43481
|
43482
|
43485
|
43486
|
43487
|
44467
|
44468
|
44469
|
44470
|
44471
|
44472
|
44473
| 44474 |
44475
|
44476
|
44477
|
44478
|
44479
|
44480
|
44481
|
44482
|
44483
|
44484
|
44485
|
44486
|
44487
|
44758
|
44845
|
44852
|
44863
|
44872