Attachment 44522 Details for Bug 7369 – Bug 7369 - duplicate item

[patch] Bug 7369 - duplicate item

Bug-7369---duplicate-item.patch (text/plain), 4.67 KB, created by Nick Clemens (kidclamp) on 2015-11-05 16:57:12 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Nick Clemens (kidclamp)

Created: 2015-11-05 16:57:12 UTC

Size: 4.67 KB

patch

obsolete

>From 022c5fa814ce712ec278b3c1355ddf0bb3e34b88 Mon Sep 17 00:00:00 2001
>From: Nick Clemens <nick@quecheelibrary.org>
>Date: Sat, 21 Mar 2015 12:27:04 -0400
>Subject: [PATCH] Bug 7369 - duplicate item
>
>This patch adds a link to duplicate existing items on the edit items screen
>
>To test:
>1 - Apply patch
>2 - navigate to the edit items screen for a record with existing items
>3 - click the duplicate link and ensure item info but not barcode are carried over
>4 - save the item and ensure it is added correctly
>5 - check that all previous functionality on page works as before
>
>Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
>
>Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
>---
> cataloguing/additem.pl                             | 34 ++++++++++++++++++++++
> .../prog/en/modules/cataloguing/additem.tt         |  3 +-
> 2 files changed, 36 insertions(+), 1 deletion(-)
>
>diff --git a/cataloguing/additem.pl b/cataloguing/additem.pl
>index b74605a..db09984 100755
>--- a/cataloguing/additem.pl
>+++ b/cataloguing/additem.pl
>@@ -585,6 +585,40 @@ if ($op eq "additem") {
>     $itemrecord = C4::Items::GetMarcItem($biblionumber,$itemnumber);
>     $nextop = "saveitem";
> #-------------------------------------------------------------------------------
>+} elsif ($op eq "dupeitem") {
>+#-------------------------------------------------------------------------------
>+# retrieve item if exist => then, it's a modif
>+    $itemrecord = C4::Items::GetMarcItem($biblionumber,$itemnumber);
>+    if (C4::Context->preference('autoBarcode') eq 'incremental') {
>+        $itemrecord = _increment_barcode($itemrecord, $frameworkcode);
>+    }
>+    else {
>+        # we have to clear the barcode field in the duplicate item record to make way for the new one generated by the javascript plugin
>+        my ($tagfield,$tagsubfield) = &GetMarcFromKohaField("items.barcode",$frameworkcode);
>+        my $fieldItem = $itemrecord->field($tagfield);
>+        $itemrecord->delete_field($fieldItem);
>+        $fieldItem->delete_subfields($tagsubfield);
>+        $itemrecord->insert_fields_ordered($fieldItem);
>+    }
>+
>+    #check for hidden subfield and remove them for the duplicated item
>+    foreach my $field ($itemrecord->fields()){
>+        my $tag = $field->{_tag};
>+        foreach my $subfield ($field->subfields()){
>+            my $subfieldtag = $subfield->[0];
>+            if (subfield_is_koha_internal_p($subfieldtag) || $tagslib->{$tag}->{$subfieldtag}->{'tab'} ne "10"
>+            ||  abs($tagslib->{$tag}->{$subfieldtag}->{hidden})>4 ){
>+                my $fieldItem = $itemrecord->field($tag);
>+                $itemrecord->delete_field($fieldItem);
>+                $fieldItem->delete_subfields($subfieldtag);
>+                $itemrecord->insert_fields_ordered($fieldItem);
>+            }
>+        }
>+    }
>+
>+    $itemrecord = removeFieldsForPrefill($itemrecord) if ($prefillitem);
>+    $nextop = "additem";
>+#-------------------------------------------------------------------------------
> } elsif ($op eq "delitem") {
> #-------------------------------------------------------------------------------
>     # check that there is no issue on this item before deletion.
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/additem.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/additem.tt
>index 1b0e317..b9db7b2 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/additem.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/additem.tt
>@@ -175,7 +175,8 @@ function confirm_deletion() {
>                         [% IF ( item_loo.hostitemflag ) %]
>                           <a href="additem.pl?op=edititem&amp;biblionumber=[% item_loo.hostbiblionumber %]&amp;itemnumber=[% item_loo.itemnumber %]#edititem">Edit in host</a> &nbsp; <a class="delete" href="/cgi-bin/koha/cataloguing/additem.pl?op=delinkitem&amp;biblionumber=[% biblionumber %]&amp;hostitemnumber=[% item_loo.itemnumber %]&searchid=[% searchid %]">Delink</a>
>                         [% ELSE %]
>-                          <a href="additem.pl?op=edititem&amp;biblionumber=[% biblionumber %]&amp;itemnumber=[% item_loo.itemnumber %]&searchid=[% searchid %]#edititem">Edit</a>
>+                          <a href="additem.pl?op=edititem&amp;biblionumber=[% biblionumber %]&amp;itemnumber=[% item_loo.itemnumber %]&amp;searchid=[% searchid %]#edititem">Edit</a>
>+                          <a href="additem.pl?op=dupeitem&amp;biblionumber=[% biblionumber %]&amp;itemnumber=[% item_loo.itemnumber %]&amp;searchid=[% searchid %]#additema">Duplicate</a>
>                           [% IF ( item_loo.countanalytics ) %]
>                             <a href="/cgi-bin/koha/catalogue/search.pl?idx=hi&amp;q=% item_loo.itemnumber %]">View analytics</a>
>                           [% ELSE %]
>-- 
>2.1.4

Actions: View | Diff | Splinter Review

Attachments on bug 7369: 37080 | 37352 | 37496 | 37498 | 37502 | 37503 | 37504 | 37505 | 37506 | 37507 | 37655 | 37656 | 44522 | 44523 | 44524