Attachment 44552 Details for Bug 14687 – [PASSED QA] Bug 14687: Patron's transaction history changes items' order after paying fines.

[patch] [PASSED QA] Bug 14687: Patron's transaction history changes items' order after paying fines.

PASSED-QA-Bug-14687-Patrons-transaction-history-ch.patch (text/plain), 1.13 KB, created by Kyle M Hall (khall) on 2015-11-06 13:00:33 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Kyle M Hall (khall)

Created: 2015-11-06 13:00:33 UTC

Size: 1.13 KB

patch

obsolete

>From 8f88d77e4e8269636ccf06d1d4b220e0fbe2478c Mon Sep 17 00:00:00 2001
>From: =?UTF-8?q?Joonas=20Kylm=C3=A4l=C3=A4?= <j.kylmala@gmail.com>
>Date: Mon, 17 Aug 2015 12:40:05 +0000
>Subject: [PATCH] [PASSED QA] Bug 14687: Patron's transaction history changes items' order after paying fines.
>
>Sorts Patron's accounting data consistently from newest to oldest.
>It doesn't depend on anymore to timestamp (which can be same for multiple
>entries) from database but instead uses accountline's id to sort.
>
>Signed-off-by: Liz Rea <liz@catalyst.net.nz>
>
>Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
>---
> C4/Members.pm |    2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
>diff --git a/C4/Members.pm b/C4/Members.pm
>index 171f3c0..e83706e 100644
>--- a/C4/Members.pm
>+++ b/C4/Members.pm
>@@ -1173,7 +1173,7 @@ sub GetMemberAccountRecords {
>                         SELECT * 
>                         FROM accountlines 
>                         WHERE borrowernumber=?);
>-    $strsth.=" ORDER BY date desc,timestamp DESC";
>+    $strsth.=" ORDER BY accountlines_id desc";
>     my $sth= $dbh->prepare( $strsth );
>     $sth->execute( $borrowernumber );
> 
>-- 
>1.7.2.5

Actions: View | Diff | Splinter Review

Attachments on bug 14687: 41553 | 44532 | 44552