Bugzilla – Attachment 44555 Details for
Bug 15120
runreport.pl doesn't allow custom subjects anymore
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[PASSED QA] Bug 15120 - runreport.pl cronjob doesn't allow custom subjects anymore
PASSED-QA-Bug-15120---runreportpl-cronjob-doesnt-a.patch (text/plain), 1.89 KB, created by
Kyle M Hall (khall)
on 2015-11-06 13:21:08 UTC
(
hide
)
Description:
[PASSED QA] Bug 15120 - runreport.pl cronjob doesn't allow custom subjects anymore
Filename:
MIME Type:
Creator:
Kyle M Hall (khall)
Created:
2015-11-06 13:21:08 UTC
Size:
1.89 KB
patch
obsolete
>From b33a96d5d00e5a792b9c19be6751daf14662890b Mon Sep 17 00:00:00 2001 >From: Liz Rea <liz@catalyst.net.nz> >Date: Wed, 4 Nov 2015 15:33:40 +1300 >Subject: [PATCH] [PASSED QA] Bug 15120 - runreport.pl cronjob doesn't allow custom subjects anymore > >To test, well do something like > >misc/cronjobs/runreport.pl --subject="My fancy subject!" --to=you@youraddress.com 1 >where 1 is the number of your favourite saved report. > >Success is your email arrives with the subject "My fancy subject!" Failure is >(with --subject defined) you get either the description of the report, or "Koha >saved report" as the subject. This is success without --subject defined. > >Signed-off-by: Frederic Demians <f.demians@tamil.fr> > Bug repeatable and fixed by this patch. > >Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> >--- > misc/cronjobs/runreport.pl | 17 ++++++++++------- > 1 files changed, 10 insertions(+), 7 deletions(-) > >diff --git a/misc/cronjobs/runreport.pl b/misc/cronjobs/runreport.pl >index 5cc000d..6b25908 100755 >--- a/misc/cronjobs/runreport.pl >+++ b/misc/cronjobs/runreport.pl >@@ -164,7 +164,7 @@ my $email = 0; > my $format = "text"; > my $to = ""; > my $from = ""; >-my $subject = 'Koha Saved Report'; >+my $subject = ""; > my $separator = ','; > my $quote = '"'; > >@@ -226,13 +226,16 @@ foreach my $report_id (@ARGV) { > my $type = $report->{type}; > > $verbose and print "SQL: $sql\n\n"; >- if (defined($report_name) and $report_name ne "") >+ if ( $subject eq "" ) > { >- $subject = $report_name ; >- } >- else >- { >- $subject = 'Koha Saved Report'; >+ if ( defined($report_name) and $report_name ne "") >+ { >+ $subject = $report_name ; >+ } >+ else >+ { >+ $subject = 'Koha Saved Report'; >+ } > } > # my $results = execute_query($sql, undef, 0, 99999, $format, $report_id); > my ($sth) = execute_query($sql); >-- >1.7.2.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 15120
:
44351
|
44461
| 44555