Bugzilla – Attachment 44583 Details for
Bug 14202
Unexpected parameter for window.open in marc21_linking_section plugin
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[PASSED QA] Bug 14202: Unexpected parameter for window.open in marc21_linking_section.pl
PASSED-QA-Bug-14202-Unexpected-parameter-for-windo.patch (text/plain), 2.22 KB, created by
Kyle M Hall (khall)
on 2015-11-06 15:50:32 UTC
(
hide
)
Description:
[PASSED QA] Bug 14202: Unexpected parameter for window.open in marc21_linking_section.pl
Filename:
MIME Type:
Creator:
Kyle M Hall (khall)
Created:
2015-11-06 15:50:32 UTC
Size:
2.22 KB
patch
obsolete
>From 831efe8cdd4fc91d79e25f87a60e3a098fa48494 Mon Sep 17 00:00:00 2001 >From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >Date: Tue, 14 Jul 2015 21:57:10 +0200 >Subject: [PATCH] [PASSED QA] Bug 14202: Unexpected parameter for window.open in marc21_linking_section.pl > >The builder of this plugin includes a window.open call with the name >parameter: \"marc21_field_7\"+ event.data.id +\"\" >Note that this is not the name of the new window. >This trivial patch adjusts this unusual name by tag_editor like other >plugins. > >Test plan: >Attach marc21_linking_section to 773$9. >Click on the Tag editor button. >If it opens, it still works :) >Note that the name of the popup is still: > Koha > Cataloguing > plugin for links > >Signed-off-by: Fredreic Demians <f.demians@tamil.fr> > Plugin still working, with a valid pop-pup window id. > >Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> >--- > .../value_builder/marc21_linking_section.pl | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > >diff --git a/cataloguing/value_builder/marc21_linking_section.pl b/cataloguing/value_builder/marc21_linking_section.pl >index 195dedb..13f3a64 100644 >--- a/cataloguing/value_builder/marc21_linking_section.pl >+++ b/cataloguing/value_builder/marc21_linking_section.pl >@@ -41,7 +41,7 @@ my $builder = sub { > <script type='text/javascript'> > function Click$function_name(event) { > defaultvalue=document.getElementById(event.data.id).value; >- window.open(\"/cgi-bin/koha/cataloguing/plugin_launcher.pl?plugin_name=marc21_linking_section.pl&index=\" + event.data.id + \"&result=\"+defaultvalue,\"marc21_field_7\"+ event.data.id +\"\",'width=900,height=700,toolbar=false,scrollbars=yes'); >+ window.open(\"/cgi-bin/koha/cataloguing/plugin_launcher.pl?plugin_name=marc21_linking_section.pl&index=\" + event.data.id + \"&result=\"+defaultvalue, 'tag_editor', 'width=900,height=700,toolbar=false,scrollbars=yes'); > > } > </script> >@@ -315,4 +315,4 @@ my $launcher = sub { > output_html_with_http_headers $query, $cookie, $template->output; > }; > >-return { builder => $builder, launcher => $launcher }; >\ No newline at end of file >+return { builder => $builder, launcher => $launcher }; >-- >1.7.2.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 14202
:
41004
|
44451
| 44583