Attachment 44748 Details for Bug 14553 – Bug 14553: Silencing warn triggered when clearing item rating on OPAC

[patch] Bug 14553: Silencing warn triggered when clearing item rating on OPAC

Bug-14553-Silencing-warn-triggered-when-clearing-i.patch (text/plain), 1.34 KB, created by Frédéric Demians on 2015-11-11 12:54:40 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Frédéric Demians

Created: 2015-11-11 12:54:40 UTC

Size: 1.34 KB

patch

obsolete

>From 16d5bd0ab6111a7eda58e988997fee7a0e0bce58 Mon Sep 17 00:00:00 2001
>From: Aleisha <aleishaamohia@hotmail.com>
>Date: Tue, 21 Jul 2015 18:38:58 +0000
>Subject: [PATCH] Bug 14553: Silencing warn triggered when clearing item rating
> on OPAC
>
>To test:
>
>1) Go to any item and clear the star rating (don't have to set a rating first)
>2) Notice the warn
>3) Apply patch and reload page
>4) Clear star rating
>5) Notice no warn
>6) Click a star to add a rating
>7) Make sure your rating, the average rating and amount of votes are all
>   correct
>8) Could be beneficial to log in as another user and try to add a rating on the
>   same item from their account. Check the average rating is
>   cacalculated and amount of votes increases
>9) Confirm still no warns
>
>Signed-off-by: Frederic Demians <f.demians@tamil.fr>
>  Can see the warning in logs, and its disappearance with this patch.
>---
> opac/opac-ratings-ajax.pl | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
>diff --git a/opac/opac-ratings-ajax.pl b/opac/opac-ratings-ajax.pl
>index 1b91caf..2d6c706 100755
>--- a/opac/opac-ratings-ajax.pl
>+++ b/opac/opac-ratings-ajax.pl
>@@ -67,10 +67,9 @@ else {
> }
> 
> my $rating;
>+$rating_value //= '';
> 
>-undef $rating_value if $rating_value eq '';
>-
>-if ( !$rating_value ) {
>+if ( $rating_value eq '' ) {
> #### delete
>     $rating = DelRating( $biblionumber, $loggedinuser );
> }
>-- 
>2.6.2

Actions: View | Diff | Splinter Review

Attachments on bug 14553: 41114 | 44748 | 44759