Bugzilla – Attachment 44831 Details for
Bug 15079
Batch Delete Records Error
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 15079 - Batch Delete Records Error
Bug-15079---Batch-Delete-Records-Error.patch (text/plain), 1.47 KB, created by
Jonathan Druart
on 2015-11-13 09:28:47 UTC
(
hide
)
Description:
Bug 15079 - Batch Delete Records Error
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2015-11-13 09:28:47 UTC
Size:
1.47 KB
patch
obsolete
>From d8d3e95a2c62aba46cf86751b88406e1a01572d2 Mon Sep 17 00:00:00 2001 >From: Kyle M Hall <kyle@bywatersolutions.com> >Date: Thu, 29 Oct 2015 07:48:02 -0400 >Subject: [PATCH] Bug 15079 - Batch Delete Records Error > >When using the batch deletion tool, if the script attempts to delete an >undeletable item, the script will die with the error: > >Label not found for "next BIBLIONUMBER" at >/usr/share/koha/intranet/cgi-bin/tools/batch_delete_records.pl line 172. > >Test Plan: >1) Attempt to batch delete a record with an item that cannot be deleted >2) Note error >3) Apply this patch >4) Repeat step 1 >5) Note the error no longer occurs > >Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> >Works as advertised. Follow comment 5 to reproduce the issue > >Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >I have not tested this patch, but looking at the code it is obviously a mistake. >If an error occured, we rollback and skip this record. >--- > tools/batch_delete_records.pl | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/tools/batch_delete_records.pl b/tools/batch_delete_records.pl >index b0523d5..65cbf21 100755 >--- a/tools/batch_delete_records.pl >+++ b/tools/batch_delete_records.pl >@@ -169,7 +169,7 @@ if ( $op eq 'form' ) { > error => ($@ ? $@ : $error), > }; > $dbh->rollback; >- next BIBLIONUMBER; >+ next RECORD_IDS; > } > } > >-- >2.1.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 15079
:
44146
|
44303
| 44831