Bugzilla – Attachment 44891 Details for
Bug 15189
The batch records modification tool should not close STDERR when running in background mode
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[PASSED QA] Bug 15189: Do not close STDERR when running in background mode
PASSED-QA-Bug-15189-Do-not-close-STDERR-when-runni.patch (text/plain), 1.12 KB, created by
Katrin Fischer
on 2015-11-16 20:08:20 UTC
(
hide
)
Description:
[PASSED QA] Bug 15189: Do not close STDERR when running in background mode
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2015-11-16 20:08:20 UTC
Size:
1.12 KB
patch
obsolete
>From 314b0ade7b859ba882133d5f68ed1e83268ae631 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Fri, 13 Nov 2015 16:22:03 +0000 >Subject: [PATCH] [PASSED QA] Bug 15189: Do not close STDERR when running in > background mode > >The batch records modification tool close STDERR, it's useless and hide >warnings/errors. > >Like the other processes using the BackgroundJob module, this one should >let it open. > >Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> > >Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> >--- > tools/batch_record_modification.pl | 1 - > 1 file changed, 1 deletion(-) > >diff --git a/tools/batch_record_modification.pl b/tools/batch_record_modification.pl >index 3aec4f7..f96ec5d 100755 >--- a/tools/batch_record_modification.pl >+++ b/tools/batch_record_modification.pl >@@ -167,7 +167,6 @@ if ( $op eq 'form' ) { > exit 0; > } elsif (defined $pid) { > close STDOUT; >- close STDERR; > } else { > warn "fork failed while attempting to run tools/batch_record_modification.pl as a background job"; > exit 0; >-- >1.9.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 15189
:
44851
|
44858
| 44891