Attachment 44896 Details for Bug 15197 – Bug 15197: In Rancor, multiple &/</" characters not escaped on saving

[patch] Bug 15197: In Rancor, multiple &/</" characters not escaped on saving

Bug-15197-In-Rancor-multiple--characters-not-escap.patch (text/plain), 1.16 KB, created by Jesse Weaver on 2015-11-16 21:58:35 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jesse Weaver

Created: 2015-11-16 21:58:35 UTC

Size: 1.16 KB

patch

obsolete

>From 07d65fa70a6288d2388b9eb6e57d7cd7500f1709 Mon Sep 17 00:00:00 2001
>From: Jesse Weaver <pianohacker@gmail.com>
>Date: Tue, 10 Nov 2015 12:12:43 -0700
>Subject: [PATCH] Bug 15197: In Rancor, multiple &/</" characters not escaped
> on saving
>
>Test plan:
>
>  1) On current master, create a record in Rancor containing multiple &, < or " characters ("A & B & C", for example).
>  2) Try to save the record, it will silently fail.
>  3) Apply this patch.
>  4) The record should now save correctly.
>---
> koha-tmpl/intranet-tmpl/lib/koha/cateditor/marc-record.js | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/lib/koha/cateditor/marc-record.js b/koha-tmpl/intranet-tmpl/lib/koha/cateditor/marc-record.js
>index d795511..fb7be33 100644
>--- a/koha-tmpl/intranet-tmpl/lib/koha/cateditor/marc-record.js
>+++ b/koha-tmpl/intranet-tmpl/lib/koha/cateditor/marc-record.js
>@@ -37,7 +37,7 @@ define( function() {
>     };
> 
>     function _escape(str) {
>-        return str.replace( /[<&"]/, function (c) { return _escape_map[c] } );
>+        return str.replace( /[<&"]/g, function (c) { return _escape_map[c] } );
>     }
> 
>     function _intpadded(i, digits) {
>-- 
>2.6.1

Actions: View | Diff | Splinter Review

Attachments on bug 15197: 44894 | 44895 | 44896 | 44897 | 44905