Bugzilla – Attachment 44935 Details for
Bug 15168
Remove C4::Serials::ItemizeSerials which is not used anymore
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 15168: (followup) remove useless diags
Bug-15168-followup-remove-useless-diags.patch (text/plain), 2.61 KB, created by
Tomás Cohen Arazi (tcohen)
on 2015-11-17 18:51:10 UTC
(
hide
)
Description:
Bug 15168: (followup) remove useless diags
Filename:
MIME Type:
Creator:
Tomás Cohen Arazi (tcohen)
Created:
2015-11-17 18:51:10 UTC
Size:
2.61 KB
patch
obsolete
>From 0ca825ed80e8a7d13da9085659d091d21aacbbac Mon Sep 17 00:00:00 2001 >From: Tomas Cohen Arazi <tomascohen@theke.io> >Date: Tue, 17 Nov 2015 15:47:46 -0300 >Subject: [PATCH] Bug 15168: (followup) remove useless diags > >While testing this bug I noticed the tests printed useless diags. >This patch removes them for good. > >Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> >--- > t/db_dependent/Serials/Frequency.t | 6 +++--- > t/db_dependent/Serials/Numberpattern.t | 6 +++--- > 2 files changed, 6 insertions(+), 6 deletions(-) > >diff --git a/t/db_dependent/Serials/Frequency.t b/t/db_dependent/Serials/Frequency.t >index 2b410db..e57ff34 100644 >--- a/t/db_dependent/Serials/Frequency.t >+++ b/t/db_dependent/Serials/Frequency.t >@@ -70,19 +70,19 @@ is($frequency->{displayorder}, 1, "displayorder OK"); > @frequencies = GetSubscriptionFrequencies(); > is(scalar @frequencies, 1, "There is one frequency"); > >-diag("Add another frequency"); >+# Add another frequency > undef $frequency->{id}; > my $id2 = AddSubscriptionFrequency($frequency); > > @frequencies = GetSubscriptionFrequencies(); > is(scalar @frequencies, 2, "There are two frequencies"); > >-diag("Delete one frequency"); >+# Delete one frequency > DelSubscriptionFrequency($id); > @frequencies = GetSubscriptionFrequencies(); > is(scalar @frequencies, 1, "There is one frequency"); > >-diag("Delete the other frequency"); >+# Delete the other frequency > DelSubscriptionFrequency($id2); > @frequencies = GetSubscriptionFrequencies(); > is(scalar @frequencies, 0, "There is no frequency"); >diff --git a/t/db_dependent/Serials/Numberpattern.t b/t/db_dependent/Serials/Numberpattern.t >index 42d3df4..6a05325 100644 >--- a/t/db_dependent/Serials/Numberpattern.t >+++ b/t/db_dependent/Serials/Numberpattern.t >@@ -83,19 +83,19 @@ foreach my $key (qw(label add every setto whenmorethan numbering)) { > @numberpatterns = GetSubscriptionNumberpatterns(); > is(scalar @numberpatterns, 1, "There is one numberpattern"); > >-diag("Add another numberpattern"); >+# Add another numberpattern > undef $numberpattern->{id}; > my $id2 = AddSubscriptionNumberpattern($numberpattern); > > @numberpatterns = GetSubscriptionNumberpatterns(); > is(scalar @numberpatterns, 2, "There are two numberpatterns"); > >-diag("Delete one numberpattern"); >+# Delete one numberpattern > DelSubscriptionNumberpattern($id); > @numberpatterns = GetSubscriptionNumberpatterns(); > is(scalar @numberpatterns, 1, "There is one numberpattern"); > >-diag("Delete the other numberpattern"); >+# Delete the other numberpattern > DelSubscriptionNumberpattern($id2); > @numberpatterns = GetSubscriptionNumberpatterns(); > is(scalar @numberpatterns, 0, "There is no numberpattern"); >-- >2.6.3
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 15168
:
44724
|
44733
|
44778
| 44935